Message ID | 1315903130.3375.7.camel@snb |
---|---|
State | Accepted, archived |
Delegated to: | David Miller |
Headers | show |
From: Lin Ming <ming.m.lin@intel.com> Date: Tue, 13 Sep 2011 16:38:50 +0800 > Subject: [PATCH -v3] netconsole: switch init_netconsole() to late_initcall > > Commit 88491d8(drivers/net: Kconfig & Makefile cleanup) causes a > regression that netconsole does not work if netconsole and network > device driver are build into kernel, because netconsole is linked > before network device driver. > > Andrew Morton suggested to fix this with initcall ordering. > Fixes it by switching init_netconsole() to late_initcall. > > Signed-off-by: Lin Ming <ming.m.lin@intel.com> Applied, thanks. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/net/netconsole.c b/drivers/net/netconsole.c index dfc8272..ed2a397 100644 --- a/drivers/net/netconsole.c +++ b/drivers/net/netconsole.c @@ -799,5 +799,11 @@ static void __exit cleanup_netconsole(void) } } -module_init(init_netconsole); +/* + * Use late_initcall to ensure netconsole is + * initialized after network device driver if built-in. + * + * late_initcall() and module_init() are identical if built as module. + */ +late_initcall(init_netconsole); module_exit(cleanup_netconsole);