| Message ID | 20190809093158.7969-3-lkundrak@v3.sk |
|---|---|
| State | Changes Requested, archived |
| Headers | show |
| Series | Initial support for Marvell MMP3 SoC | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success |
On Fri, Aug 09, 2019 at 11:31:41AM +0200, Lubomir Rintel wrote: > Marvel MMP3 is a successor to MMP2, containing similar peripherals with two > PJ4B cores. > > Signed-off-by: Lubomir Rintel <lkundrak@v3.sk> > --- > Documentation/devicetree/bindings/arm/mrvl/mrvl.txt | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/Documentation/devicetree/bindings/arm/mrvl/mrvl.txt b/Documentation/devicetree/bindings/arm/mrvl/mrvl.txt > index 951687528efb0..66e1e1414245b 100644 > --- a/Documentation/devicetree/bindings/arm/mrvl/mrvl.txt > +++ b/Documentation/devicetree/bindings/arm/mrvl/mrvl.txt > @@ -12,3 +12,7 @@ Required root node properties: > MMP2 Brownstone Board > Required root node properties: > - compatible = "mrvl,mmp2-brownstone", "mrvl,mmp2"; > + > +MMP3 SoC > +Required root node properties: > + - compatible = "marvell,mmp3"; Please convert this file to DT schema before adding new SoCs. Rob
On Wed, 2019-08-21 at 16:03 -0500, Rob Herring wrote: > On Fri, Aug 09, 2019 at 11:31:41AM +0200, Lubomir Rintel wrote: > > Marvel MMP3 is a successor to MMP2, containing similar peripherals with two > > PJ4B cores. > > > > Signed-off-by: Lubomir Rintel <lkundrak@v3.sk> > > --- > > Documentation/devicetree/bindings/arm/mrvl/mrvl.txt | 4 ++++ > > 1 file changed, 4 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/arm/mrvl/mrvl.txt b/Documentation/devicetree/bindings/arm/mrvl/mrvl.txt > > index 951687528efb0..66e1e1414245b 100644 > > --- a/Documentation/devicetree/bindings/arm/mrvl/mrvl.txt > > +++ b/Documentation/devicetree/bindings/arm/mrvl/mrvl.txt > > @@ -12,3 +12,7 @@ Required root node properties: > > MMP2 Brownstone Board > > Required root node properties: > > - compatible = "mrvl,mmp2-brownstone", "mrvl,mmp2"; > > + > > +MMP3 SoC > > +Required root node properties: > > + - compatible = "marvell,mmp3"; > > Please convert this file to DT schema before adding new SoCs. Is this something that should generally be done for all new or changed DT bindings? > > Rob Thanks Lubo
On Thu, Aug 22, 2019 at 3:12 AM Lubomir Rintel <lkundrak@v3.sk> wrote: > > On Wed, 2019-08-21 at 16:03 -0500, Rob Herring wrote: > > On Fri, Aug 09, 2019 at 11:31:41AM +0200, Lubomir Rintel wrote: > > > Marvel MMP3 is a successor to MMP2, containing similar peripherals with two > > > PJ4B cores. > > > > > > Signed-off-by: Lubomir Rintel <lkundrak@v3.sk> > > > --- > > > Documentation/devicetree/bindings/arm/mrvl/mrvl.txt | 4 ++++ > > > 1 file changed, 4 insertions(+) > > > > > > diff --git a/Documentation/devicetree/bindings/arm/mrvl/mrvl.txt b/Documentation/devicetree/bindings/arm/mrvl/mrvl.txt > > > index 951687528efb0..66e1e1414245b 100644 > > > --- a/Documentation/devicetree/bindings/arm/mrvl/mrvl.txt > > > +++ b/Documentation/devicetree/bindings/arm/mrvl/mrvl.txt > > > @@ -12,3 +12,7 @@ Required root node properties: > > > MMP2 Brownstone Board > > > Required root node properties: > > > - compatible = "mrvl,mmp2-brownstone", "mrvl,mmp2"; > > > + > > > +MMP3 SoC > > > +Required root node properties: > > > + - compatible = "marvell,mmp3"; > > > > Please convert this file to DT schema before adding new SoCs. > > Is this something that should generally be done for all new or changed > DT bindings? Preferred, but not quite yet required everywhere. It depends on the maintainer/subsystem still. But for board level bindings, you'll notice most of them are converted. Marvell, Broadcom, and TI are the main ones left. Rob
diff --git a/Documentation/devicetree/bindings/arm/mrvl/mrvl.txt b/Documentation/devicetree/bindings/arm/mrvl/mrvl.txt index 951687528efb0..66e1e1414245b 100644 --- a/Documentation/devicetree/bindings/arm/mrvl/mrvl.txt +++ b/Documentation/devicetree/bindings/arm/mrvl/mrvl.txt @@ -12,3 +12,7 @@ Required root node properties: MMP2 Brownstone Board Required root node properties: - compatible = "mrvl,mmp2-brownstone", "mrvl,mmp2"; + +MMP3 SoC +Required root node properties: + - compatible = "marvell,mmp3";
Marvel MMP3 is a successor to MMP2, containing similar peripherals with two PJ4B cores. Signed-off-by: Lubomir Rintel <lkundrak@v3.sk> --- Documentation/devicetree/bindings/arm/mrvl/mrvl.txt | 4 ++++ 1 file changed, 4 insertions(+)