| Message ID | 20190809062000.8671-4-yixin.zhang@intel.com |
|---|---|
| State | Rejected |
| Delegated to: | Petr Vorel |
| Headers | show |
| Series | [1/5] runtest/scsi_debug.part1: remove duplicated test for reiserfs filesystem | expand |
Hi Yixin, > mem01 is already in runtest file mm. Rename the test to mem01_crashme > here. ... > -mem01 mem01 -r > +mem01_crashme mem01 -r > # Memory eater. Loves to be run in parallel with other programs. > # May panic on buggy systems if the OOM killer was not fast enough :-) > fork12 fork12 Refused this one, as it's the same case as [5/5]. Quote Cyril: https://patchwork.ozlabs.org/comment/2234376/ The test names in runtest files were never promised to be unique, if the command line is the same the test id should probably stay the same. Kind regards, Petr
Hi Petr, Understood and thanks. Could you aslo have a look at "[PATCH ltp 3/5] runtest/ltp-aiodio.part4: rename aiodio_append tests to avoid duplication"? That case is different than this one. In that case cases with differnt commands share the same name. Br. Yixin On 2019-08-30 at 15:14:00 +0200, Petr Vorel wrote: > Hi Yixin, > > > mem01 is already in runtest file mm. Rename the test to mem01_crashme > > here. > > ... > > -mem01 mem01 -r > > +mem01_crashme mem01 -r > > # Memory eater. Loves to be run in parallel with other programs. > > # May panic on buggy systems if the OOM killer was not fast enough :-) > > fork12 fork12 > > Refused this one, as it's the same case as [5/5]. Quote Cyril: > https://patchwork.ozlabs.org/comment/2234376/ > The test names in runtest files were never promised to be unique, if the > command line is the same the test id should probably stay the same. > > > Kind regards, > Petr
diff --git a/runtest/crashme b/runtest/crashme index a4c5b41cc..e853663e6 100644 --- a/runtest/crashme +++ b/runtest/crashme @@ -10,7 +10,7 @@ crash01 crash01 crash02 crash02 # Generate random syscalls and execute them, less probability # to hose your system, but still. -mem01 mem01 -r +mem01_crashme mem01 -r # Memory eater. Loves to be run in parallel with other programs. # May panic on buggy systems if the OOM killer was not fast enough :-) fork12 fork12
mem01 is already in runtest file mm. Rename the test to mem01_crashme here. Signed-off-by: Yixin Zhang <yixin.zhang@intel.com> --- runtest/crashme | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)