| Message ID | 20190809002941.15341-3-liuhangbin@gmail.com |
|---|---|
| State | Rejected |
| Delegated to: | David Miller |
| Headers | show |
| Series | Add netdev_level_ratelimited to avoid netdev msg flush | expand |
diff --git a/drivers/net/ethernet/ibm/ibmveth.c b/drivers/net/ethernet/ibm/ibmveth.c index d654c234aaf7..138523ee5e84 100644 --- a/drivers/net/ethernet/ibm/ibmveth.c +++ b/drivers/net/ethernet/ibm/ibmveth.c @@ -1446,9 +1446,8 @@ static void ibmveth_set_multicast_list(struct net_device *netdev) IbmVethMcastAddFilter, mcast_addr); if (lpar_rc != H_SUCCESS) { - netdev_err(netdev, "h_multicast_ctrl rc=%ld " - "when adding an entry to the filter " - "table\n", lpar_rc); + netdev_err_ratelimited(netdev, "h_multicast_ctrl rc=%ld when adding an entry to the filter table\n", + lpar_rc); } }
When add lots of (e.g. add 3000) memberships in one multicast group on ibmveth, the following error message flushes our console log file 8507 [ 901.478251] ibmveth 30000003 env3: h_multicast_ctrl rc=4 when adding an entry to the filter table ... 1718386 [ 5636.808658] ibmveth 30000003 env3: h_multicast_ctrl rc=4 when adding an entry to the filter table We got 1.5 million lines of messages in 1.3h. Let's replace netdev_err() by netdev_err_ratelimited() to avoid this issue. Signed-off-by: Hangbin Liu <liuhangbin@gmail.com> --- drivers/net/ethernet/ibm/ibmveth.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-)