Message ID | 1565308020-31952-3-git-send-email-skomatineni@nvidia.com |
---|---|
State | Superseded |
Headers | show |
Series | SC7 entry and exit support for Tegra210 | expand |
09.08.2019 2:46, Sowjanya Komatineni пишет: > This patch adds write barrier after all pinctrl register writes > during resume to make sure all pinctrl changes are complete. > > Signed-off-by: Sowjanya Komatineni <skomatineni@nvidia.com> > --- > drivers/pinctrl/tegra/pinctrl-tegra.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/pinctrl/tegra/pinctrl-tegra.c b/drivers/pinctrl/tegra/pinctrl-tegra.c > index 982ee634b3b1..f49fe29fb6df 100644 > --- a/drivers/pinctrl/tegra/pinctrl-tegra.c > +++ b/drivers/pinctrl/tegra/pinctrl-tegra.c > @@ -677,6 +677,8 @@ static int tegra_pinctrl_resume(struct device *dev) > writel_relaxed(*backup_regs++, regs++); > } > > + /* make sure all the pinmux register writes are complete */ > + wmb(); > return 0; > } > > Reviewed-by: Dmitry Osipenko <digetx@gmail.com>
On Thu, Aug 08, 2019 at 04:46:41PM -0700, Sowjanya Komatineni wrote: > This patch adds write barrier after all pinctrl register writes > during resume to make sure all pinctrl changes are complete. > > Signed-off-by: Sowjanya Komatineni <skomatineni@nvidia.com> > --- > drivers/pinctrl/tegra/pinctrl-tegra.c | 2 ++ > 1 file changed, 2 insertions(+) Acked-by: Thierry Reding <treding@nvidia.com>
On Fri, Aug 9, 2019 at 1:47 AM Sowjanya Komatineni <skomatineni@nvidia.com> wrote: > This patch adds write barrier after all pinctrl register writes > during resume to make sure all pinctrl changes are complete. > > Signed-off-by: Sowjanya Komatineni <skomatineni@nvidia.com> Patch applied with the ACKs. Yours, Linus Walleij
diff --git a/drivers/pinctrl/tegra/pinctrl-tegra.c b/drivers/pinctrl/tegra/pinctrl-tegra.c index 982ee634b3b1..f49fe29fb6df 100644 --- a/drivers/pinctrl/tegra/pinctrl-tegra.c +++ b/drivers/pinctrl/tegra/pinctrl-tegra.c @@ -677,6 +677,8 @@ static int tegra_pinctrl_resume(struct device *dev) writel_relaxed(*backup_regs++, regs++); } + /* make sure all the pinmux register writes are complete */ + wmb(); return 0; }
This patch adds write barrier after all pinctrl register writes during resume to make sure all pinctrl changes are complete. Signed-off-by: Sowjanya Komatineni <skomatineni@nvidia.com> --- drivers/pinctrl/tegra/pinctrl-tegra.c | 2 ++ 1 file changed, 2 insertions(+)