Patchwork [U-Boot] mx31pdk: Remove unneeded config

login
register
mail settings
Submitter Fabio Estevam
Date Sept. 12, 2011, 4:32 p.m.
Message ID <1315845154-11875-1-git-send-email-fabio.estevam@freescale.com>
Download mbox | patch
Permalink /patch/114404/
State Accepted
Commit e56daf635b4ae3598fcac83269dc659bff696cca
Delegated to: Stefano Babic
Headers show

Comments

Fabio Estevam - Sept. 12, 2011, 4:32 p.m.
Currently there are two config options for building a U-boot binary for MX31PDK:

make mx31pdk_config

or, 

make mx31pdk_nand_config

mx31pdk_config was developed first when no NAND SPL support was available for 
MX31 and it requires that the U-boot binary is loaded into RAM via JTAG and it 
forces SKIP_LOWLEVEL_INIT.

mx31pdk_nand_config was added later and it allows booting from NAND Flash.

Leave just one config option called mx31pdk so that it produces a binary that can boot from NAND Flash.

Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
---

This applies on Stefano's origin/next branch.

 boards.cfg |    3 +--
 1 files changed, 1 insertions(+), 2 deletions(-)
Stefano Babic - Sept. 13, 2011, 11:10 a.m.
On 09/12/2011 06:32 PM, Fabio Estevam wrote:
> Currently there are two config options for building a U-boot binary for MX31PDK:
> 
> make mx31pdk_config
> 
> or, 
> 
> make mx31pdk_nand_config
> 
> mx31pdk_config was developed first when no NAND SPL support was available for 
> MX31 and it requires that the U-boot binary is loaded into RAM via JTAG and it 
> forces SKIP_LOWLEVEL_INIT.
> 
> mx31pdk_nand_config was added later and it allows booting from NAND Flash.
> 
> Leave just one config option called mx31pdk so that it produces a binary that can boot from NAND Flash.
> 
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>

Agree, nand is the only way to boot this board.

Acked-by: Stefano Babic <sbabic@denx.de>

Best regards,
Stefano Babic
Fabio Estevam - Oct. 10, 2011, 3:28 p.m.
Hi Wolfgang,

On Tue, Sep 13, 2011 at 8:10 AM, Stefano Babic <sbabic@denx.de> wrote:
> On 09/12/2011 06:32 PM, Fabio Estevam wrote:
>> Currently there are two config options for building a U-boot binary for MX31PDK:
>>
>> make mx31pdk_config
>>
>> or,
>>
>> make mx31pdk_nand_config
>>
>> mx31pdk_config was developed first when no NAND SPL support was available for
>> MX31 and it requires that the U-boot binary is loaded into RAM via JTAG and it
>> forces SKIP_LOWLEVEL_INIT.
>>
>> mx31pdk_nand_config was added later and it allows booting from NAND Flash.
>>
>> Leave just one config option called mx31pdk so that it produces a binary that can boot from NAND Flash.
>>
>> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
>
> Agree, nand is the only way to boot this board.
>
> Acked-by: Stefano Babic <sbabic@denx.de>

Ping?

Regards,

Fabio Estevam
Stefano Babic - Oct. 10, 2011, 3:41 p.m.
On 10/10/2011 05:28 PM, Fabio Estevam wrote:
> Hi Wolfgang,
> 
> On Tue, Sep 13, 2011 at 8:10 AM, Stefano Babic <sbabic@denx.de> wrote:
>> On 09/12/2011 06:32 PM, Fabio Estevam wrote:
>>> Currently there are two config options for building a U-boot binary for MX31PDK:
>>>
>>> make mx31pdk_config
>>>
>>> or,
>>>
>>> make mx31pdk_nand_config
>>>
>>> mx31pdk_config was developed first when no NAND SPL support was available for
>>> MX31 and it requires that the U-boot binary is loaded into RAM via JTAG and it
>>> forces SKIP_LOWLEVEL_INIT.
>>>
>>> mx31pdk_nand_config was added later and it allows booting from NAND Flash.
>>>
>>> Leave just one config option called mx31pdk so that it produces a binary that can boot from NAND Flash.
>>>
>>> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
>>
>> Agree, nand is the only way to boot this board.
>>
>> Acked-by: Stefano Babic <sbabic@denx.de>
> 
> Ping?

Sorry, your patch is in my queue and I have not yet merged because I
needed the other patches ("Makefile: remove mx31pdk exception" and
"Makefile: drop imx31_phycore from general Makefile") to apply it. They
are now in mainline, so I can merge it.

Best regards,
Stefano Babic
Stefano Babic - Oct. 10, 2011, 3:43 p.m.
On 09/12/2011 06:32 PM, Fabio Estevam wrote:
> Currently there are two config options for building a U-boot binary for MX31PDK:
> 
> make mx31pdk_config
> 
> or, 
> 
> make mx31pdk_nand_config
> 
> mx31pdk_config was developed first when no NAND SPL support was available for 
> MX31 and it requires that the U-boot binary is loaded into RAM via JTAG and it 
> forces SKIP_LOWLEVEL_INIT.
> 
> mx31pdk_nand_config was added later and it allows booting from NAND Flash.
> 
> Leave just one config option called mx31pdk so that it produces a binary that can boot from NAND Flash.
> 
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
> ---
> 

Applied to u-boot-imx, thanks.

Best regards,
Stefano Babic
Wolfgang Denk - Oct. 10, 2011, 5:46 p.m.
Dear Fabio Estevam,

In message <CAOMZO5C0PE3F+4H8t7sVpsfUcjUFp_-Z27ZzQrObYnNvY5sPHw@mail.gmail.com> you wrote:
> 
> Ping?

Pong.  What's up?  This is i.MX, and I haven't seen any ARM (nor even
i.MX) pull requests yet.

Best regards,

Wolfgang Denk

Patch

diff --git a/boards.cfg b/boards.cfg
index 446ed04..1e2ff43 100644
--- a/boards.cfg
+++ b/boards.cfg
@@ -41,8 +41,7 @@  mx31ads                      arm         arm1136     -                   freesca
 imx31_litekit                arm         arm1136     -                   logicpd        mx31
 imx31_phycore                arm         arm1136     -                   -              mx31
 imx31_phycore_eet            arm         arm1136     imx31_phycore       -              mx31         imx31_phycore:IMX31_PHYCORE_EET
-mx31pdk_nand                 arm         arm1136     mx31pdk             freescale      mx31         mx31pdk:NAND_U_BOOT
-mx31pdk                      arm         arm1136     -                   freescale      mx31         mx31pdk:SKIP_LOWLEVEL_INIT
+mx31pdk                      arm         arm1136     -                   freescale      mx31         mx31pdk:NAND_U_BOOT
 mx35pdk                      arm         arm1136     -                   freescale      mx35
 omap2420h4                   arm         arm1136     -                   ti             omap24xx
 tnetv107x_evm                arm         arm1176     tnetv107xevm        ti             tnetv107x