Patchwork [U-Boot,01/11] FEC: Use proper accessor to read register in debug call

login
register
mail settings
Submitter Marek Vasut
Date Sept. 12, 2011, 4:05 a.m.
Message ID <1315800339-19823-2-git-send-email-marek.vasut@gmail.com>
Download mbox | patch
Permalink /patch/114266/
State Accepted
Delegated to: Stefano Babic
Headers show

Comments

Marek Vasut - Sept. 12, 2011, 4:05 a.m.
Signed-off-by: Marek Vasut <marek.vasut@gmail.com>
Cc: Ben Warren <biggerbadderben@gmail.com>
Cc: Stefano Babic <sbabic@denx.de>
Cc: Wolfgang Denk <wd@denx.de>
Cc: Detlev Zundel <dzu@denx.de>
---
 drivers/net/fec_mxc.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
Stefano Babic - Sept. 22, 2011, 10:55 a.m.
On 09/12/2011 06:05 AM, Marek Vasut wrote:
> Signed-off-by: Marek Vasut <marek.vasut@gmail.com>
> Cc: Ben Warren <biggerbadderben@gmail.com>
> Cc: Stefano Babic <sbabic@denx.de>
> Cc: Wolfgang Denk <wd@denx.de>
> Cc: Detlev Zundel <dzu@denx.de>
> ---
>  drivers/net/fec_mxc.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/net/fec_mxc.c b/drivers/net/fec_mxc.c
> index ab90afa..82fe1e4 100644
> --- a/drivers/net/fec_mxc.c
> +++ b/drivers/net/fec_mxc.c
> @@ -117,7 +117,7 @@ static void fec_mii_setspeed(struct fec_priv *fec)
>  	writel((((imx_get_fecclk() / 1000000) + 2) / 5) << 1,
>  			&fec->eth->mii_speed);
>  	debug("fec_init: mii_speed %#lx\n",
> -			fec->eth->mii_speed);
> +			readl(&fec->eth->mii_speed));
>  }
>  static int fec_miiphy_write(const char *dev, uint8_t phyAddr, uint8_t regAddr,
>  		uint16_t data)

As agreed with Wolfgang, I push this series directly to u-boot-imx.

Applied to u-boot-imx, next branch, thanks.

Best regards,
Stefano Babic

Patch

diff --git a/drivers/net/fec_mxc.c b/drivers/net/fec_mxc.c
index ab90afa..82fe1e4 100644
--- a/drivers/net/fec_mxc.c
+++ b/drivers/net/fec_mxc.c
@@ -117,7 +117,7 @@  static void fec_mii_setspeed(struct fec_priv *fec)
 	writel((((imx_get_fecclk() / 1000000) + 2) / 5) << 1,
 			&fec->eth->mii_speed);
 	debug("fec_init: mii_speed %#lx\n",
-			fec->eth->mii_speed);
+			readl(&fec->eth->mii_speed));
 }
 static int fec_miiphy_write(const char *dev, uint8_t phyAddr, uint8_t regAddr,
 		uint16_t data)