diff mbox series

[OpenWrt-Devel] kernel: drop Fon(Foxconn) parser matching for the "firmware" partition

Message ID 20190806080115.17406-1-zajec5@gmail.com
State Accepted
Headers show
Series [OpenWrt-Devel] kernel: drop Fon(Foxconn) parser matching for the "firmware" partition | expand

Commit Message

Rafał Miłecki Aug. 6, 2019, 8:01 a.m. UTC 
From: Rafał Miłecki <rafal@milecki.pl>

This parser's matching function appears to be too generic as it matches
e.g. Buffalo WZR-HP-G300NH. That results in incorrect parts parsing.

Luckily this parser is needed by Fon FON2601 only which uses DT-based
ramips target. It means we can depend on mtd subsystem matching of
"fonfxc,uimage" string.

That said triggering this parser based on the "firmware" (or whatever
MTD_SPLIT_FIRMWARE_NAME is) partiiton name is not needed. It can be
dropped which will automatically fix the Buffalo WZR-HP-G300NH case.

Fixes: a1c6a316d299 ("ramips: add support for Fon FON2601")
Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
---
 .../linux/generic/files/drivers/mtd/mtdsplit/mtdsplit_uimage.c   | 1 -
 1 file changed, 1 deletion(-)
diff mbox series

Patch

diff --git a/target/linux/generic/files/drivers/mtd/mtdsplit/mtdsplit_uimage.c b/target/linux/generic/files/drivers/mtd/mtdsplit/mtdsplit_uimage.c
index 091403ae91..41347d0419 100644
--- a/target/linux/generic/files/drivers/mtd/mtdsplit/mtdsplit_uimage.c
+++ b/target/linux/generic/files/drivers/mtd/mtdsplit/mtdsplit_uimage.c
@@ -421,7 +421,6 @@  static struct mtd_part_parser uimage_fonfxc_parser = {
 	.of_match_table = mtdsplit_uimage_fonfxc_of_match_table,
 #endif
 	.parse_fn = mtdsplit_uimage_parse_fonfxc,
-	.type = MTD_PARSER_TYPE_FIRMWARE,
 };
 
 /**************************************************