From patchwork Tue Aug 6 01:37:19 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alistair Popple X-Patchwork-Id: 1142527 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 462chs6gcyz9sDB for ; Tue, 6 Aug 2019 11:38:05 +1000 (AEST) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=popple.id.au Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 462chs15kNzDqXf for ; Tue, 6 Aug 2019 11:38:05 +1000 (AEST) X-Original-To: pdbg@lists.ozlabs.org Delivered-To: pdbg@lists.ozlabs.org Received: from ozlabs.org (bilbo.ozlabs.org [203.11.71.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 462chK6X0rzDqWh for ; Tue, 6 Aug 2019 11:37:37 +1000 (AEST) Authentication-Results: lists.ozlabs.org; dmarc=none (p=none dis=none) header.from=popple.id.au Received: from authenticated.ozlabs.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mail.ozlabs.org (Postfix) with ESMTPSA id 462chK1fjdz9sDB; Tue, 6 Aug 2019 11:37:37 +1000 (AEST) From: Alistair Popple To: pdbg@lists.ozlabs.org Date: Tue, 6 Aug 2019 11:37:19 +1000 Message-Id: <20190806013723.4047-9-alistair@popple.id.au> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190806013723.4047-1-alistair@popple.id.au> References: <20190806013723.4047-1-alistair@popple.id.au> MIME-Version: 1.0 Subject: [Pdbg] [RFC 08/12] libpdbg: Change get_target_class() to take a pdbg_target X-BeenThere: pdbg@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "mailing list for https://github.com/open-power/pdbg development" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: amitay@ozlabs.org Errors-To: pdbg-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org Sender: "Pdbg" No behavioural change. Signed-off-by: Alistair Popple Reviewed-by: Amitay Isaacs --- libpdbg/device.c | 2 +- libpdbg/target.c | 8 ++++---- libpdbg/target.h | 2 +- 3 files changed, 6 insertions(+), 6 deletions(-) diff --git a/libpdbg/device.c b/libpdbg/device.c index 21ec3a3..f6d27db 100644 --- a/libpdbg/device.c +++ b/libpdbg/device.c @@ -110,7 +110,7 @@ static struct pdbg_target *pdbg_target_new(const void *fdt, int node_offset) * guaranteed to be the struct pdbg_target (see the comment * above DECLARE_HW_UNIT). */ memcpy(target, hw_info->hw_unit, size); - target_class = get_target_class(target->class); + target_class = get_target_class(target); list_add_tail(&target_class->targets, &target->class_link); return target; diff --git a/libpdbg/target.c b/libpdbg/target.c index e822d70..73ad98f 100644 --- a/libpdbg/target.c +++ b/libpdbg/target.c @@ -334,18 +334,18 @@ struct pdbg_target_class *require_target_class(const char *name) } /* Returns the existing class or allocates space for a new one */ -struct pdbg_target_class *get_target_class(const char *name) +struct pdbg_target_class *get_target_class(struct pdbg_target *target) { struct pdbg_target_class *target_class; - if ((target_class = find_target_class(name))) + if ((target_class = find_target_class(target->class))) return target_class; /* Need to allocate a new class */ - PR_DEBUG("Allocating %s target class\n", name); + PR_DEBUG("Allocating %s target class\n", target->class); target_class = calloc(1, sizeof(*target_class)); assert(target_class); - target_class->name = strdup(name); + target_class->name = strdup(target->class); list_head_init(&target_class->targets); list_add_tail(&target_classes, &target_class->class_head_link); return target_class; diff --git a/libpdbg/target.h b/libpdbg/target.h index 2c76bf9..44cbcde 100644 --- a/libpdbg/target.h +++ b/libpdbg/target.h @@ -56,7 +56,7 @@ struct pdbg_target { struct pdbg_target *require_target_parent(struct pdbg_target *target); struct pdbg_target_class *find_target_class(const char *name); struct pdbg_target_class *require_target_class(const char *name); -struct pdbg_target_class *get_target_class(const char *name); +struct pdbg_target_class *get_target_class(struct pdbg_target *target); bool pdbg_target_is_class(struct pdbg_target *target, const char *class); extern struct list_head empty_list;