Patchwork [U-Boot] ARM: hawkboard: fix compilation of nand_spl

login
register
mail settings
Submitter Wolfgang Denk
Date Sept. 10, 2011, 8:28 p.m.
Message ID <1315686495-9133-1-git-send-email-wd@denx.de>
Download mbox | patch
Permalink /patch/114198/
State Accepted
Commit 3b7175524939ffc73af2b8eb1ee5166838d3f260
Headers show

Comments

Wolfgang Denk - Sept. 10, 2011, 8:28 p.m.
Fix build problem:

nand_spl/board/davinci/da8xxevm/hawkboard_nand_spl.c: In function 'board_init_f':
nand_spl/board/davinci/da8xxevm/hawkboard_nand_spl.c:132: warning: implicit declaration of function 'nand_boot'
nand_spl/board/davinci/da8xxevm/hawkboard_nand_spl.c:133: warning: 'noreturn' function does return

Signed-off-by: Wolfgang Denk <wd@denx.de>
Cc: Syed Mohammed Khasim <sm.khasim@gmail.com>
Cc: Sughosh Ganu <urwithsughosh@gmail.com>
Cc: Albert ARIBAUD <albert.u.boot@aribaud.net>
---
 board/davinci/da8xxevm/hawkboard_nand_spl.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
Wolfgang Denk - Sept. 10, 2011, 8:46 p.m.
Dear Wolfgang Denk,

In message <1315686495-9133-1-git-send-email-wd@denx.de> you wrote:
> Fix build problem:
> 
> nand_spl/board/davinci/da8xxevm/hawkboard_nand_spl.c: In function 'board_init_f':
> nand_spl/board/davinci/da8xxevm/hawkboard_nand_spl.c:132: warning: implicit declaration of function 'nand_boot'
> nand_spl/board/davinci/da8xxevm/hawkboard_nand_spl.c:133: warning: 'noreturn' function does return
> 
> Signed-off-by: Wolfgang Denk <wd@denx.de>
> Cc: Syed Mohammed Khasim <sm.khasim@gmail.com>
> Cc: Sughosh Ganu <urwithsughosh@gmail.com>
> Cc: Albert ARIBAUD <albert.u.boot@aribaud.net>
> ---
>  board/davinci/da8xxevm/hawkboard_nand_spl.c |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)

Applied, thanks.

Best regards,

Wolfgang Denk
Albert ARIBAUD - Sept. 11, 2011, 3:59 p.m.
Hi Wolfgang,

Le 10/09/2011 22:46, Wolfgang Denk a écrit :
> Dear Wolfgang Denk,
>
> In message<1315686495-9133-1-git-send-email-wd@denx.de>  you wrote:
>> Fix build problem:
>>
>> nand_spl/board/davinci/da8xxevm/hawkboard_nand_spl.c: In function 'board_init_f':
>> nand_spl/board/davinci/da8xxevm/hawkboard_nand_spl.c:132: warning: implicit declaration of function 'nand_boot'
>> nand_spl/board/davinci/da8xxevm/hawkboard_nand_spl.c:133: warning: 'noreturn' function does return
>>
>> Signed-off-by: Wolfgang Denk<wd@denx.de>
>> Cc: Syed Mohammed Khasim<sm.khasim@gmail.com>
>> Cc: Sughosh Ganu<urwithsughosh@gmail.com>
>> Cc: Albert ARIBAUD<albert.u.boot@aribaud.net>
>> ---
>>   board/davinci/da8xxevm/hawkboard_nand_spl.c |    1 +
>>   1 files changed, 1 insertions(+), 0 deletions(-)
>
> Applied, thanks.
>
> Best regards,
>
> Wolfgang Denk

I'd already applied this patch from Stefano to u-boot-arm/master.

Amicalement,
Albert ARIBAUD - Sept. 11, 2011, 4:11 p.m.
Le 11/09/2011 17:59, Albert ARIBAUD a écrit :
> Hi Wolfgang,
>
> Le 10/09/2011 22:46, Wolfgang Denk a écrit :
>> Dear Wolfgang Denk,
>>
>> In message<1315686495-9133-1-git-send-email-wd@denx.de>   you wrote:
>>> Fix build problem:
>>>
>>> nand_spl/board/davinci/da8xxevm/hawkboard_nand_spl.c: In function 'board_init_f':
>>> nand_spl/board/davinci/da8xxevm/hawkboard_nand_spl.c:132: warning: implicit declaration of function 'nand_boot'
>>> nand_spl/board/davinci/da8xxevm/hawkboard_nand_spl.c:133: warning: 'noreturn' function does return
>>>
>>> Signed-off-by: Wolfgang Denk<wd@denx.de>
>>> Cc: Syed Mohammed Khasim<sm.khasim@gmail.com>
>>> Cc: Sughosh Ganu<urwithsughosh@gmail.com>
>>> Cc: Albert ARIBAUD<albert.u.boot@aribaud.net>
>>> ---
>>>    board/davinci/da8xxevm/hawkboard_nand_spl.c |    1 +
>>>    1 files changed, 1 insertions(+), 0 deletions(-)
>>
>> Applied, thanks.
>>
>> Best regards,
>>
>> Wolfgang Denk
>
> I'd already applied this patch from Stefano to u-boot-arm/master.

Correction: you, not I, had already applied a patch with the exact same 
title and different content.

Amicalement,
Wolfgang Denk - Sept. 11, 2011, 6:03 p.m.
Dear Albert ARIBAUD,

In message <4E6CDAEB.6050404@aribaud.net> you wrote:
> 
> I'd already applied this patch from Stefano to u-boot-arm/master.

This is no problem - git will sort it out automatically.

Sorry for going ahead, I wanted to clean up the ARM build finally.

Best regards,

Wolfgang Denk
Wolfgang Denk - Sept. 11, 2011, 6:04 p.m.
Dear Albert ARIBAUD,

In message <4E6CDDC8.5040300@aribaud.net> you wrote:
>
> > I'd already applied this patch from Stefano to u-boot-arm/master.
> 
> Correction: you, not I, had already applied a patch with the exact same 
> title and different content.

Yes, there were several problems with this board :-(

Best regards,

Wolfgang Denk

Patch

diff --git a/board/davinci/da8xxevm/hawkboard_nand_spl.c b/board/davinci/da8xxevm/hawkboard_nand_spl.c
index 9155236..e5e65e5 100644
--- a/board/davinci/da8xxevm/hawkboard_nand_spl.c
+++ b/board/davinci/da8xxevm/hawkboard_nand_spl.c
@@ -28,6 +28,7 @@ 
 #include <asm/io.h>
 #include <asm/arch/davinci_misc.h>
 #include <ns16550.h>
+#include <nand.h>
 
 DECLARE_GLOBAL_DATA_PTR;