Patchwork [U-Boot] cm4008, cm41xx: fix build warnings

login
register
mail settings
Submitter Wolfgang Denk
Date Sept. 10, 2011, 3:01 p.m.
Message ID <1315666885-4666-1-git-send-email-wd@denx.de>
Download mbox | patch
Permalink /patch/114189/
State Accepted
Commit bd6ce9d171b45465daa23bede5214100dd8b5eba
Headers show

Comments

Wolfgang Denk - Sept. 10, 2011, 3:01 p.m.
Fix these:
cm4008.c: In function 'board_eth_init':
cm4008.c:79: warning: implicit declaration of function 'ks8695_eth_initialize'

cm41xx.c: In function 'board_eth_init':
cm41xx.c:79: warning: implicit declaration of function 'ks8695_eth_initialize'

While we are at it, sort include list in netdev.h

Signed-off-by: Wolfgang Denk <wd@denx.de>
Cc: Greg Ungerer <greg.ungerer@opengear.com>
---
 board/cm4008/cm4008.c |    1 +
 board/cm41xx/cm41xx.c |    1 +
 include/netdev.h      |   18 +++++++++---------
 3 files changed, 11 insertions(+), 9 deletions(-)
Wolfgang Denk - Sept. 10, 2011, 8:46 p.m.
Dear Wolfgang Denk,

In message <1315666885-4666-1-git-send-email-wd@denx.de> you wrote:
> Fix these:
> cm4008.c: In function 'board_eth_init':
> cm4008.c:79: warning: implicit declaration of function 'ks8695_eth_initialize'
> 
> cm41xx.c: In function 'board_eth_init':
> cm41xx.c:79: warning: implicit declaration of function 'ks8695_eth_initialize'
> 
> While we are at it, sort include list in netdev.h
> 
> Signed-off-by: Wolfgang Denk <wd@denx.de>
> Cc: Greg Ungerer <greg.ungerer@opengear.com>
> ---
>  board/cm4008/cm4008.c |    1 +
>  board/cm41xx/cm41xx.c |    1 +
>  include/netdev.h      |   18 +++++++++---------
>  3 files changed, 11 insertions(+), 9 deletions(-)

Applied, thanks.

Best regards,

Wolfgang Denk

Patch

diff --git a/board/cm4008/cm4008.c b/board/cm4008/cm4008.c
index 2e8d948..ed493a8 100644
--- a/board/cm4008/cm4008.c
+++ b/board/cm4008/cm4008.c
@@ -30,6 +30,7 @@ 
 
 #include <common.h>
 #include <asm/arch/platform.h>
+#include <netdev.h>
 
 DECLARE_GLOBAL_DATA_PTR;
 
diff --git a/board/cm41xx/cm41xx.c b/board/cm41xx/cm41xx.c
index 72fd64d..d9dff4e 100644
--- a/board/cm41xx/cm41xx.c
+++ b/board/cm41xx/cm41xx.c
@@ -30,6 +30,7 @@ 
 
 #include <common.h>
 #include <asm/arch/platform.h>
+#include <netdev.h>
 
 DECLARE_GLOBAL_DATA_PTR;
 
diff --git a/include/netdev.h b/include/netdev.h
index 83d7886..96c7b9b 100644
--- a/include/netdev.h
+++ b/include/netdev.h
@@ -43,30 +43,32 @@  int cpu_eth_init(bd_t *bis);
 /* Driver initialization prototypes */
 int altera_tse_initialize(u8 dev_num, int mac_base,
 			  int sgdma_rx_base, int sgdma_tx_base);
-int ax88180_initialize(bd_t *bis);
-int au1x00_enet_initialize(bd_t*);
 int at91emac_register(bd_t *bis, unsigned long iobase);
+int au1x00_enet_initialize(bd_t*);
+int ax88180_initialize(bd_t *bis);
 int bfin_EMAC_initialize(bd_t *bis);
 int cs8900_initialize(u8 dev_num, int base_addr);
-int dc21x4x_initialize(bd_t *bis);
 int davinci_emac_initialize(void);
+int dc21x4x_initialize(bd_t *bis);
 int designware_initialize(u32 id, ulong base_addr, u32 phy_addr);
+int dm9000_initialize(bd_t *bis);
 int dnet_eth_initialize(int id, void *regs, unsigned int phy_addr);
 int e1000_initialize(bd_t *bis);
 int eepro100_initialize(bd_t *bis);
 int enc28j60_initialize(unsigned int bus, unsigned int cs,
 	unsigned int max_hz, unsigned int mode);
 int ep93xx_eth_initialize(u8 dev_num, int base_addr);
-int ethoc_initialize(u8 dev_num, int base_addr);
 int eth_3com_initialize (bd_t * bis);
+int ethoc_initialize(u8 dev_num, int base_addr);
 int fec_initialize (bd_t *bis);
 int fecmxc_initialize (bd_t *bis);
+int fecmxc_initialize(bd_t *bis);
 int ftgmac100_initialize(bd_t *bits);
 int ftmac100_initialize(bd_t *bits);
 int greth_initialize(bd_t *bis);
 void gt6426x_eth_initialize(bd_t *bis);
 int inca_switch_initialize(bd_t *bis);
-int ks8695_eth_initialize(bd_t *bis);
+int ks8695_eth_initialize(void);
 int lan91c96_initialize(u8 dev_num, int base_addr);
 int macb_eth_initialize(int id, void *regs, unsigned int phy_addr);
 int mcdmafec_initialize(bd_t *bis);
@@ -85,16 +87,14 @@  int ppc_4xx_eth_initialize (bd_t *bis);
 int rtl8139_initialize(bd_t *bis);
 int rtl8169_initialize(bd_t *bis);
 int scc_initialize(bd_t *bis);
+int sh_eth_initialize(bd_t *bis);
 int skge_initialize(bd_t *bis);
-int smc911x_initialize(u8 dev_num, int base_addr);
 int smc91111_initialize(u8 dev_num, int base_addr);
+int smc911x_initialize(u8 dev_num, int base_addr);
 int tsi108_eth_initialize(bd_t *bis);
 int uec_standard_init(bd_t *bis);
 int uli526x_initialize(bd_t *bis);
 int xilinx_emaclite_initialize (bd_t *bis, int base_addr);
-int sh_eth_initialize(bd_t *bis);
-int dm9000_initialize(bd_t *bis);
-int fecmxc_initialize(bd_t *bis);
 
 /* Boards with PCI network controllers can call this from their board_eth_init()
  * function to initialize whatever's on board.