[v13,3/5] package/gdb: depend on libiberty
diff mbox series

Message ID 20190804001429.51451-3-aduskett@gmail.com
State New
Headers show
Series
  • [v13,1/5] package/libiberty: new package
Related show

Commit Message

Adam Duskett Aug. 4, 2019, 12:14 a.m. UTC
From: Adam Duskett <Aduskett@gmail.com>

If present, GDB may use a system installed libiberty. As such, we must ensure
that host-libiberty is installed first.

Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
Signed-off-by: Adam Duskett <Aduskett@gmail.com>
---
v1 -> v11:
  - Add this patch to the series

 package/gdb/gdb.mk | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

Comments

Arnout Vandecappelle (Essensium/Mind) Aug. 4, 2019, 8:17 a.m. UTC | #1
On 04/08/2019 02:14, aduskett@gmail.com wrote:
> From: Adam Duskett <Aduskett@gmail.com>
> 
> If present, GDB may use a system installed libiberty. As such, we must ensure
> that host-libiberty is installed first.
> 
> Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
> Signed-off-by: Adam Duskett <Aduskett@gmail.com>
> ---
> v1 -> v11:
>   - Add this patch to the series
> 
>  package/gdb/gdb.mk | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/package/gdb/gdb.mk b/package/gdb/gdb.mk
> index 46d745a897..39d20be1aa 100644
> --- a/package/gdb/gdb.mk
> +++ b/package/gdb/gdb.mk
> @@ -35,7 +35,9 @@ endif
>  # For the host variant, we really want to build with XML support,
>  # which is needed to read XML descriptions of target architectures. We
>  # also need ncurses.
> -HOST_GDB_DEPENDENCIES = host-expat host-ncurses
> +# As for libiberty, gdb may use a system-isntalled one if present, so
                                            ^^^installed

 Regards,
 Arnout

> +# we must ensure ours is installed first.
> +HOST_GDB_DEPENDENCIES = host-expat host-libiberty host-ncurses
>  
>  # Disable building documentation
>  GDB_MAKE_OPTS += MAKEINFO=true
>

Patch
diff mbox series

diff --git a/package/gdb/gdb.mk b/package/gdb/gdb.mk
index 46d745a897..39d20be1aa 100644
--- a/package/gdb/gdb.mk
+++ b/package/gdb/gdb.mk
@@ -35,7 +35,9 @@  endif
 # For the host variant, we really want to build with XML support,
 # which is needed to read XML descriptions of target architectures. We
 # also need ncurses.
-HOST_GDB_DEPENDENCIES = host-expat host-ncurses
+# As for libiberty, gdb may use a system-isntalled one if present, so
+# we must ensure ours is installed first.
+HOST_GDB_DEPENDENCIES = host-expat host-libiberty host-ncurses
 
 # Disable building documentation
 GDB_MAKE_OPTS += MAKEINFO=true