diff mbox

[U-Boot,v2,6/7] Add bootgraph instrumentation for UBoot commands

Message ID 1315658227-4388-6-git-send-email-amurray@theiet.org
State Changes Requested
Headers show

Commit Message

Andrew Murray Sept. 10, 2011, 12:37 p.m. UTC 
From: Andrew Murray <amurray@mpcdata.com>

This patch adds bootgraph instrumentation for all U_BOOT_CMDs where the
HUSH parser is not used. The patch also adds instrumentation for the
common boot delay.
---
Changes for v2:
	- Use improved DO_INITCALL_RET macro

Signed-off-by: Andrew Murray <amurray@theiet.org>
---
 common/main.c |    8 ++++----
 1 files changed, 4 insertions(+), 4 deletions(-)

Comments

Mike Frysinger Sept. 18, 2011, 2:11 a.m. UTC | #1 
On Saturday, September 10, 2011 08:37:06 Andrew Murray wrote:
> --- a/common/main.c
> +++ b/common/main.c
>
> @@ -385,11 +385,11 @@ void main_loop (void)
>  		run_command (s, 0);
>  # else
>  		parse_string_outer(s, FLAG_PARSE_SEMICOLON |
> -				    FLAG_EXIT_FROM_LOOP);
> +			    FLAG_EXIT_FROM_LOOP);
>  # endif
> 
>  # ifdef CONFIG_AUTOBOOT_KEYED
> -		disable_ctrlc(prev);	/* restore Control C checking */
> +			disable_ctrlc(prev);	/* restore Control C checking */
>  # endif
>  	}
> 

i dont see any functional changes here, so just drop these hunks
-mike
Wolfgang Denk Oct. 6, 2011, 9:35 p.m. UTC | #2 
Dear Andrew Murray,

In message <1315658227-4388-6-git-send-email-amurray@theiet.org> you wrote:
> From: Andrew Murray <amurray@mpcdata.com>
> 
> This patch adds bootgraph instrumentation for all U_BOOT_CMDs where the
> HUSH parser is not used. The patch also adds instrumentation for the
> common boot delay.
> ---
> Changes for v2:
> 	- Use improved DO_INITCALL_RET macro
> 
> Signed-off-by: Andrew Murray <amurray@theiet.org>
> ---
>  common/main.c |    8 ++++----
>  1 files changed, 4 insertions(+), 4 deletions(-)


Checkpatch says:

total: 0 errors, 1 warnings, 29 lines checked

Please clean up and resubmit.  Thanks.

Best regards,

Wolfgang Denk
diff mbox

Patch

diff --git a/common/main.c b/common/main.c
index 2730c6f..bf95463 100644
--- a/common/main.c
+++ b/common/main.c
@@ -376,7 +376,7 @@  void main_loop (void)
 
 	debug ("### main_loop: bootcmd=\"%s\"\n", s ? s : "<UNDEFINED>");
 
-	if (bootdelay >= 0 && s && !abortboot (bootdelay)) {
+	if (bootdelay >= 0 && s && !DO_INITCALL_RET(abortboot, bootdelay)) {
 # ifdef CONFIG_AUTOBOOT_KEYED
 		int prev = disable_ctrlc(1);	/* disable Control C checking */
 # endif
@@ -385,11 +385,11 @@  void main_loop (void)
 		run_command (s, 0);
 # else
 		parse_string_outer(s, FLAG_PARSE_SEMICOLON |
-				    FLAG_EXIT_FROM_LOOP);
+			    FLAG_EXIT_FROM_LOOP);
 # endif
 
 # ifdef CONFIG_AUTOBOOT_KEYED
-		disable_ctrlc(prev);	/* restore Control C checking */
+			disable_ctrlc(prev);	/* restore Control C checking */
 # endif
 	}
 
@@ -1371,7 +1371,7 @@  int run_command (const char *cmd, int flag)
 #endif
 
 		/* OK - call function to do the command */
-		if ((cmdtp->cmd) (cmdtp, flag, argc, argv) != 0) {
+		if (DO_INITCALL_RET(cmdtp->cmd, cmdtp, flag, argc, argv) != 0) {
 			rc = -1;
 		}