From patchwork Sat Aug 3 01:55:56 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Rosen Penev X-Patchwork-Id: 1141423 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=uclibc.org (client-ip=140.211.166.138; helo=whitealder.osuosl.org; envelope-from=uclibc-bounces@uclibc.org; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="PkGoHHnB"; dkim-atps=neutral Received: from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 460nF64fQmz9sMr for ; Sat, 3 Aug 2019 11:56:08 +1000 (AEST) Received: from localhost (localhost [127.0.0.1]) by whitealder.osuosl.org (Postfix) with ESMTP id 8217387767; Sat, 3 Aug 2019 01:56:04 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from whitealder.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id JKinzvwdN7ba; Sat, 3 Aug 2019 01:56:03 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by whitealder.osuosl.org (Postfix) with ESMTP id B4BB48773D; Sat, 3 Aug 2019 01:56:03 +0000 (UTC) X-Original-To: uclibc@lists.busybox.net Delivered-To: uclibc@osuosl.org Received: from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138]) by ash.osuosl.org (Postfix) with ESMTP id C82D31BF360 for ; Sat, 3 Aug 2019 01:56:01 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by whitealder.osuosl.org (Postfix) with ESMTP id C54B78701C for ; Sat, 3 Aug 2019 01:56:01 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from whitealder.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id BXCCjiYAD5c1 for ; Sat, 3 Aug 2019 01:56:01 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from mail-pf1-f195.google.com (mail-pf1-f195.google.com [209.85.210.195]) by whitealder.osuosl.org (Postfix) with ESMTPS id 401C08773D for ; Sat, 3 Aug 2019 01:56:01 +0000 (UTC) Received: by mail-pf1-f195.google.com with SMTP id i189so36869357pfg.10 for ; Fri, 02 Aug 2019 18:56:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:subject:date:message-id:in-reply-to:references; bh=8g7sMtH4w634iM91ojOehIb5CvYClst3Rf4DE0Ay3PI=; b=PkGoHHnBKAKdh0CamSDsm6OtT6gqzTs+MJSUY3uYdekMBjoveZLW3vadWjlDf4xijw b8Fql/Fd6ymAGsy4o22/oy9uhqKsOY5rtTep9PPX/SivUOAXIDYS9u9QLIZ/c/tDtQiR ypLhRYwGPaOaV5apxjwES7vo+C3SMgF6MCb8T7qslbnzZwHnM/PHxJuSubdDPA5VCDiC p8RPeCinjk66u/Zi3eEF6++KfX+JwpzI0S+zm1+dYePTBIpQ6liWqCAlHcuC/6C7pkhC nLQRBBmg6b5EJ3UkC2HFV6SHBphIvqb6nKwvYb3rBYWbCjtw0QXvkXfQOvmEUjNY0b5S al4w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to :references; bh=8g7sMtH4w634iM91ojOehIb5CvYClst3Rf4DE0Ay3PI=; b=K9mSO9lvEpWFtPWU6l2SzJwqepLOKbXgpOlZXHzq09B6i3rQKyEEvk5wmYz3noOrRM 8T/FOxOqQ9B0p5yzvAd6YQg34bZA0/e/1cDJYRaWpJhDtsZxlGrqiVCrPjt+kguhODYG gCJKoi9Ox2NtJUwAqLdIL1n/91jFr4a36segQuM4RR+FV1fm60EMQ6tkkMeHV6gjvqHU T92AeCVtbXN+Xqac1CE/AbP66vGIA897JBsY89Lypy0zmr9S9/UQyY7q/z0MZNu9o5Q4 ST/wLlstcurPrIhGb5OxdlD14sGwzFoomSiTfBPqpgqcEHw6weyfQC4b49SmMiaodLaA rLqw== X-Gm-Message-State: APjAAAUHHcg4xelzc+IkxfjxIAdgVGOww3vQ3KYaR1TKPZLfYH/Xyw6x u00+wA+aFaOWL6liBF1x167KsDtYa2c= X-Google-Smtp-Source: APXvYqxfexSwVKI1TVTNibhksjQ1fqZMcYjyHzfV9A9i85EMjolhIytRCnRh+ias1vPGAUOzDoMlbA== X-Received: by 2002:a17:90a:35e5:: with SMTP id r92mr7187358pjb.34.1564797360595; Fri, 02 Aug 2019 18:56:00 -0700 (PDT) Received: from localhost.localdomain (76-14-106-55.rk.wavecable.com. [76.14.106.55]) by smtp.gmail.com with ESMTPSA id s24sm33424167pgm.3.2019.08.02.18.55.59 for (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Fri, 02 Aug 2019 18:56:00 -0700 (PDT) From: Rosen Penev To: uclibc@uclibc.org Subject: [PATCH 2/4] iterator: Add missing parentheses Date: Fri, 2 Aug 2019 18:55:56 -0700 Message-Id: <20190803015558.4143-2-rosenp@gmail.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20190803015558.4143-1-rosenp@gmail.com> References: <20190803015558.4143-1-rosenp@gmail.com> X-BeenThere: uclibc@uclibc.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Discussion and development of uClibc \(the embedded C library\)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: uclibc-bounces@uclibc.org Sender: "uClibc" Clang warns: warning: '&&' within '||' [-Wlogical-op-parentheses] return sbuf == b.sbuf || is_eof() && b.is_eof(); Signed-off-by: Rosen Penev --- include/iterator | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/iterator b/include/iterator index d65f467..3348d85 100644 --- a/include/iterator +++ b/include/iterator @@ -164,7 +164,7 @@ namespace std{ } bool equal(const istreambuf_iterator& b) const{ - return sbuf == b.sbuf || is_eof() && b.is_eof(); + return sbuf == b.sbuf || (is_eof() && b.is_eof()); } private: streambuf_type* sbuf;