| Message ID | 20190802105457.16596-1-hslester96@gmail.com |
|---|---|
| State | Rejected |
| Delegated to: | Jeff Kirsher |
| Headers | show |
| Series | [1/2] ixgbe: Explicitly initialize reference count to 0 | expand |
> -----Original Message----- > From: Intel-wired-lan [mailto:intel-wired-lan-bounces@osuosl.org] On > Behalf Of Chuhong Yuan > Sent: Friday, August 2, 2019 3:55 AM > Cc: netdev@vger.kernel.org; Chuhong Yuan <hslester96@gmail.com>; linux- > kernel@vger.kernel.org; intel-wired-lan@lists.osuosl.org; David S . Miller > <davem@davemloft.net> > Subject: [Intel-wired-lan] [PATCH 1/2] ixgbe: Explicitly initialize reference > count to 0 > > The driver does not explicitly call atomic_set to initialize refcount to 0. > Add the call so that it will be more straight forward to convert refcount from > atomic_t to refcount_t. > > Signed-off-by: Chuhong Yuan <hslester96@gmail.com> > --- > drivers/net/ethernet/intel/ixgbe/ixgbe_fcoe.c | 1 + > 1 file changed, 1 insertion(+) Tested-by: Andrew Bowers <andrewx.bowers@intel.com>
On Mon, Aug 5, 2019 at 2:42 PM Bowers, AndrewX <andrewx.bowers@intel.com> wrote: > > > -----Original Message----- > > From: Intel-wired-lan [mailto:intel-wired-lan-bounces@osuosl.org] On > > Behalf Of Chuhong Yuan > > Sent: Friday, August 2, 2019 3:55 AM > > Cc: netdev@vger.kernel.org; Chuhong Yuan <hslester96@gmail.com>; linux- > > kernel@vger.kernel.org; intel-wired-lan@lists.osuosl.org; David S . Miller > > <davem@davemloft.net> > > Subject: [Intel-wired-lan] [PATCH 1/2] ixgbe: Explicitly initialize reference > > count to 0 > > > > The driver does not explicitly call atomic_set to initialize refcount to 0. > > Add the call so that it will be more straight forward to convert refcount from > > atomic_t to refcount_t. > > > > Signed-off-by: Chuhong Yuan <hslester96@gmail.com> > > --- > > drivers/net/ethernet/intel/ixgbe/ixgbe_fcoe.c | 1 + > > 1 file changed, 1 insertion(+) > > Tested-by: Andrew Bowers <andrewx.bowers@intel.com> NAK. This patch is badly broken. We should not be resetting the fcoe refcnt in ixgbe_setup_fcoe_ddp_resources.
diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_fcoe.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_fcoe.c index ccd852ad62a4..00710f43cfd2 100644 --- a/drivers/net/ethernet/intel/ixgbe/ixgbe_fcoe.c +++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_fcoe.c @@ -773,6 +773,7 @@ int ixgbe_setup_fcoe_ddp_resources(struct ixgbe_adapter *adapter) fcoe->extra_ddp_buffer = buffer; fcoe->extra_ddp_buffer_dma = dma; + atomic_set(&fcoe->refcnt, 0); /* allocate pci pool for each cpu */ for_each_possible_cpu(cpu) {
The driver does not explicitly call atomic_set to initialize refcount to 0. Add the call so that it will be more straight forward to convert refcount from atomic_t to refcount_t. Signed-off-by: Chuhong Yuan <hslester96@gmail.com> --- drivers/net/ethernet/intel/ixgbe/ixgbe_fcoe.c | 1 + 1 file changed, 1 insertion(+)