diff mbox series

firmware: tegra: Move BPMP resume to noirq phase

Message ID 20190802061727.18177-1-vidyas@nvidia.com
State Accepted
Headers show
Series firmware: tegra: Move BPMP resume to noirq phase | expand

Commit Message

Vidya Sagar Aug. 2, 2019, 6:17 a.m. UTC
Modules like PCIe in Tegra194 need BPMP firmware services in noirq phase
and hence move BPMP resume to noirq phase.
This patch is verified on Tegra210, Tegra186 and Tegra194.

Signed-off-by: Vidya Sagar <vidyas@nvidia.com>
---
 drivers/firmware/tegra/bpmp.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Vidya Sagar Aug. 5, 2019, 6:54 a.m. UTC | #1
On 8/2/2019 11:47 AM, Vidya Sagar wrote:

Timo / Sivaram / Stefan,
Can you please review this change?

Thanks,
Vidya Sagar

> Modules like PCIe in Tegra194 need BPMP firmware services in noirq phase
> and hence move BPMP resume to noirq phase.
> This patch is verified on Tegra210, Tegra186 and Tegra194.
> 
> Signed-off-by: Vidya Sagar <vidyas@nvidia.com>
> ---
>   drivers/firmware/tegra/bpmp.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/firmware/tegra/bpmp.c b/drivers/firmware/tegra/bpmp.c
> index 19c56133234b..6741fcda0c37 100644
> --- a/drivers/firmware/tegra/bpmp.c
> +++ b/drivers/firmware/tegra/bpmp.c
> @@ -804,7 +804,7 @@ static int __maybe_unused tegra_bpmp_resume(struct device *dev)
>   }
>   
>   static const struct dev_pm_ops tegra_bpmp_pm_ops = {
> -	.resume_early = tegra_bpmp_resume,
> +	.resume_noirq = tegra_bpmp_resume,
>   };
>   
>   #if IS_ENABLED(CONFIG_ARCH_TEGRA_186_SOC) || \
>
Timo Alho Aug. 5, 2019, 1:21 p.m. UTC | #2
On 2.8.2019 9.17, Vidya Sagar wrote:
> Modules like PCIe in Tegra194 need BPMP firmware services in noirq phase
> and hence move BPMP resume to noirq phase.
> This patch is verified on Tegra210, Tegra186 and Tegra194.
> 
> Signed-off-by: Vidya Sagar <vidyas@nvidia.com>
> ---
>   drivers/firmware/tegra/bpmp.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/firmware/tegra/bpmp.c b/drivers/firmware/tegra/bpmp.c
> index 19c56133234b..6741fcda0c37 100644
> --- a/drivers/firmware/tegra/bpmp.c
> +++ b/drivers/firmware/tegra/bpmp.c
> @@ -804,7 +804,7 @@ static int __maybe_unused tegra_bpmp_resume(struct device *dev)
>   }
>   
>   static const struct dev_pm_ops tegra_bpmp_pm_ops = {
> -	.resume_early = tegra_bpmp_resume,
> +	.resume_noirq = tegra_bpmp_resume,
>   };
>   
>   #if IS_ENABLED(CONFIG_ARCH_TEGRA_186_SOC) || \
> 

Looks good.

Reviewed-by: Timo Alho <talho@nvidia.com>
Thierry Reding Aug. 7, 2019, 12:43 p.m. UTC | #3
On Fri, Aug 02, 2019 at 11:47:27AM +0530, Vidya Sagar wrote:
> Modules like PCIe in Tegra194 need BPMP firmware services in noirq phase
> and hence move BPMP resume to noirq phase.
> This patch is verified on Tegra210, Tegra186 and Tegra194.
> 
> Signed-off-by: Vidya Sagar <vidyas@nvidia.com>
> ---
>  drivers/firmware/tegra/bpmp.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Applied, thanks.

Thierry
diff mbox series

Patch

diff --git a/drivers/firmware/tegra/bpmp.c b/drivers/firmware/tegra/bpmp.c
index 19c56133234b..6741fcda0c37 100644
--- a/drivers/firmware/tegra/bpmp.c
+++ b/drivers/firmware/tegra/bpmp.c
@@ -804,7 +804,7 @@  static int __maybe_unused tegra_bpmp_resume(struct device *dev)
 }
 
 static const struct dev_pm_ops tegra_bpmp_pm_ops = {
-	.resume_early = tegra_bpmp_resume,
+	.resume_noirq = tegra_bpmp_resume,
 };
 
 #if IS_ENABLED(CONFIG_ARCH_TEGRA_186_SOC) || \