Patchwork [U-Boot] ARM: hawkboard_nand: fix compilation of nand_spl

login
register
mail settings
Submitter Stefano Babic
Date Sept. 9, 2011, 9:37 a.m.
Message ID <1315561023-7015-1-git-send-email-sbabic@denx.de>
Download mbox | patch
Permalink /patch/114037/
State Changes Requested
Headers show

Comments

Stefano Babic - Sept. 9, 2011, 9:37 a.m.
get_ram_size() is called, but memsize.c is not compiled.

Signed-off-by: Stefano Babic <sbabic@denx.de>
---
 nand_spl/board/davinci/da8xxevm/Makefile |   21 ++++++++++++++++++---
 1 files changed, 18 insertions(+), 3 deletions(-)
Wolfgang Denk - Sept. 9, 2011, 11:40 a.m.
Dear Stefano Babic,

In message <1315561023-7015-1-git-send-email-sbabic@denx.de> you wrote:
> get_ram_size() is called, but memsize.c is not compiled.
> 
> Signed-off-by: Stefano Babic <sbabic@denx.de>
> ---
>  nand_spl/board/davinci/da8xxevm/Makefile |   21 ++++++++++++++++++---
>  1 files changed, 18 insertions(+), 3 deletions(-)

So, what is this now?  v1? v2? anything else?

And what exactly has been changed?

Why is there no version in the Subject, and no Changelog in the
comment section?

Best regards,

Wolfgang Denk
Stefano Babic - Sept. 9, 2011, 12:40 p.m.
On 09/09/2011 01:40 PM, Wolfgang Denk wrote:
> Dear Stefano Babic,
> 
> In message <1315561023-7015-1-git-send-email-sbabic@denx.de> you wrote:
>> get_ram_size() is called, but memsize.c is not compiled.
>>
>> Signed-off-by: Stefano Babic <sbabic@denx.de>
>> ---
>>  nand_spl/board/davinci/da8xxevm/Makefile |   21 ++++++++++++++++++---
>>  1 files changed, 18 insertions(+), 3 deletions(-)
> 
> So, what is this now?  v1? v2? anything else?
> 
> And what exactly has been changed?
> 
> Why is there no version in the Subject, and no Changelog in the
> comment section?

There is only one reason: I forget to do it !

ok, I will try again...

Best regards,
Stefano Babic

Patch

diff --git a/nand_spl/board/davinci/da8xxevm/Makefile b/nand_spl/board/davinci/da8xxevm/Makefile
index b3f4bd6..c82f6c6 100644
--- a/nand_spl/board/davinci/da8xxevm/Makefile
+++ b/nand_spl/board/davinci/da8xxevm/Makefile
@@ -36,9 +36,20 @@  LDFLAGS := -T $(nandobj)u-boot.lds -Ttext $(CONFIG_SYS_TEXT_BASE) $(LDFLAGS) \
 AFLAGS	+= -DCONFIG_SPL_BUILD -DCONFIG_NAND_SPL
 CFLAGS	+= -DCONFIG_SPL_BUILD -DCONFIG_NAND_SPL
 
-SOBJS	= start.o _udivsi3.o _divsi3.o
-COBJS	= cpu.o davinci_nand.o ns16550.o div0.o davinci_pinmux.o psc.o	\
-	misc.o hawkboard_nand_spl.o nand_boot.o
+SOBJS	= _divsi3.o \
+	_udivsi3.o \
+	start.o
+
+COBJS	= cpu.o \
+	davinci_nand.o \
+	davinci_pinmux.o \
+	div0.o \
+	hawkboard_nand_spl.o \
+	memsize.o \
+	misc.o \
+	nand_boot.o \
+	ns16550.o \
+	psc.o
 
 SRCS	:= $(addprefix $(obj),$(SOBJS:.o=.S) $(COBJS:.o=.c))
 OBJS	:= $(addprefix $(obj),$(SOBJS) $(COBJS))
@@ -125,6 +136,10 @@  $(obj)psc.c:
 	@rm -f $@
 	ln -s $(TOPDIR)/arch/arm/cpu/arm926ejs/davinci/psc.c $@
 
+# from comon directory
+$(obj)memsize.c:
+	@rm -f $@
+	ln -s $(TOPDIR)/common/memsize.c $@
 
 #########################################################################