Patchwork [3/7] linux-user: Exit with an error if we couldn't set up gdbserver

login
register
mail settings
Submitter riku.voipio@linaro.org
Date Sept. 9, 2011, 9:32 a.m.
Message ID <ff7a981affbbc4f19f6f92143a3ddff90a1363fe.1315560307.git.riku.voipio@linaro.org>
Download mbox | patch
Permalink /patch/114032/
State New
Headers show

Comments

riku.voipio@linaro.org - Sept. 9, 2011, 9:32 a.m.
From: Peter Maydell <peter.maydell@linaro.org>

If gdbserver_start() fails (usually because we couldn't bind to the
requested TCP port) then exit qemu rather than blithely continuing.
This brings the linux-user behaviour in to line with system mode.

Signed-off-by: Riku Voipio <riku.voipio@linaro.org>
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
---
 linux-user/main.c |    6 +++++-
 1 files changed, 5 insertions(+), 1 deletions(-)

Patch

diff --git a/linux-user/main.c b/linux-user/main.c
index 25cb4dd..8910d2c 100644
--- a/linux-user/main.c
+++ b/linux-user/main.c
@@ -3655,7 +3655,11 @@  int main(int argc, char **argv, char **envp)
 #endif
 
     if (gdbstub_port) {
-        gdbserver_start (gdbstub_port);
+        if (gdbserver_start(gdbstub_port) < 0) {
+            fprintf(stderr, "qemu: could not open gdbserver on port %d\n",
+                    gdbstub_port);
+            exit(1);
+        }
         gdb_handlesig(env, 0);
     }
     cpu_loop(env);