From patchwork Thu Sep 8 17:03:52 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [v2, 2/3] ARM: iwmmxt: Port problematic iwmmxt support code to v7/Thumb-2 Date: Thu, 08 Sep 2011 07:03:52 -0000 From: Eric Miao X-Patchwork-Id: 113926 Message-Id: To: Arnd Bergmann Cc: Dave Martin , Haojian Zhuang , linux-arm-kernel@lists.infradead.org, patches@linaro.org On Thu, Sep 8, 2011 at 9:45 AM, Arnd Bergmann wrote: > On Thursday 08 September 2011, Dave Martin wrote: >> The iwmmxt code contains some code to implement a pseudo-ISB, but >> this is not buildable for Thumb-2. >> >> This patch replaces the pseudo-ISB with a real one for Thumb-2 >> kernels. >> >> Signed-off-by: Dave Martin >> --- >>  arch/arm/kernel/iwmmxt.S |    9 +++++++++ >>  1 files changed, 9 insertions(+), 0 deletions(-) > > Acked-by: Arnd Bergmann > Maybe it'll be much simpler to have something like below: diff --git a/arch/arm/kernel/iwmmxt.S b/arch/arm/kernel/iwmmxt.S index a087838..5998f7d 100644 --- a/arch/arm/kernel/iwmmxt.S +++ b/arch/arm/kernel/iwmmxt.S @@ -319,8 +319,9 @@ ENTRY(iwmmxt_task_switch) PJ4(eor r1, r1, #0xf) PJ4(mcr p15, 0, r1, c1, c0, 2) - mrc p15, 0, r1, c2, c0, 0 - sub pc, lr, r1, lsr #32 @ cpwait and return + XSC(mrc p15, 0, r1, c2, c0, 0) + PJ4(isb) + mov pc, lr @ cpwait and return /* * Remove Concan ownership of given task