Patchwork ti816x: add support for nand on ti8168 evm

login
register
mail settings
Submitter Saxena, Parth
Date Sept. 8, 2011, 1:03 p.m.
Message ID <1315486982-30109-1-git-send-email-parth.saxena@ti.com>
Download mbox | patch
Permalink /patch/113901/
State New
Headers show

Comments

Saxena, Parth - Sept. 8, 2011, 1:03 p.m.
Add partition table for NAND device on TI8168 EVM
and initialise the NAND module.

Signed-off-by: Saxena, Parth <parth.saxena@ti.com>
Signed-off-by: Basheer, Mansoor Ahamed <mansoor.ahamed@ti.com>
---

This patch is tested on top of linux-omap/master and
Hemant's patches submitted recently.

http://www.mail-archive.com/linux-omap@vger.kernel.org/msg53457.html
http://www.mail-archive.com/linux-omap@vger.kernel.org/msg54296.html

 arch/arm/mach-omap2/board-ti8168evm.c |   39 +++++++++++++++++++++++++++++++++
 1 files changed, 39 insertions(+), 0 deletions(-)
Saxena, Parth - Sept. 14, 2011, 11:10 a.m.
If there are no review comments on this patch, can this be merged?

Thanks and Regards,
Parth

> -----Original Message-----
> From: Saxena, Parth
> Sent: Thursday, September 08, 2011 6:33 PM
> To: linux-mtd@lists.infradead.org
> Cc: linux-omap@vger.kernel.org; Saxena, Parth; Basheer, Mansoor Ahamed
> Subject: [PATCH] ti816x: add support for nand on ti8168 evm
> 
> Add partition table for NAND device on TI8168 EVM
> and initialise the NAND module.
> 
> Signed-off-by: Saxena, Parth <parth.saxena@ti.com>
> Signed-off-by: Basheer, Mansoor Ahamed <mansoor.ahamed@ti.com>
> ---
> 
> This patch is tested on top of linux-omap/master and
> Hemant's patches submitted recently.
> 
> http://www.mail-archive.com/linux-omap@vger.kernel.org/msg53457.html
> http://www.mail-archive.com/linux-omap@vger.kernel.org/msg54296.html
> 
>  arch/arm/mach-omap2/board-ti8168evm.c |   39
> +++++++++++++++++++++++++++++++++
>  1 files changed, 39 insertions(+), 0 deletions(-)
> 
> diff --git a/arch/arm/mach-omap2/board-ti8168evm.c b/arch/arm/mach-
> omap2/board-ti8168evm.c
> index e516a04..87953bb 100644
> --- a/arch/arm/mach-omap2/board-ti8168evm.c
> +++ b/arch/arm/mach-omap2/board-ti8168evm.c
> @@ -14,6 +14,7 @@
>   */
>  #include <linux/kernel.h>
>  #include <linux/init.h>
> +#include <linux/mtd/nand.h>
> 
>  #include <mach/hardware.h>
>  #include <asm/mach-types.h>
> @@ -23,6 +24,42 @@
>  #include <plat/irqs.h>
>  #include <plat/board.h>
>  #include <plat/common.h>
> +#include <plat/gpmc.h>
> +#include <plat/nand.h>
> +
> +#include "board-flash.h"
> +
> +#define NAND_BLOCK_SIZE		SZ_128K
> +
> +static struct mtd_partition ti816x_nand_partitions[] = {
> +/* All the partition sizes are listed in terms of NAND block size */
> +	{
> +		.name		= "U-Boot",
> +		.offset		= 0,			/* Offset = 0x0 */
> +		.size		= 18 * NAND_BLOCK_SIZE,
> +		.mask_flags	= MTD_WRITEABLE,	/* force read-only */
> +	},
> +	{
> +		.name		= "U-Boot Env",
> +		.offset		= MTDPART_OFS_APPEND,	/* Offset = 0x240000
> */
> +		.size		= 2 * NAND_BLOCK_SIZE,
> +	},
> +	{
> +		.name		= "Kernel",
> +		.offset		= MTDPART_OFS_APPEND,	/* Offset = 0x280000
> */
> +		.size		= 34 * NAND_BLOCK_SIZE,
> +	},
> +	{
> +		.name		= "File System",
> +		.offset		= MTDPART_OFS_APPEND,	/* Offset = 0x6C0000
> */
> +		.size		= 1601 * NAND_BLOCK_SIZE,
> +	},
> +	{
> +		.name		= "Reserved",
> +		.offset		= MTDPART_OFS_APPEND,	/* Offset =
> 0xCEE0000 */
> +		.size		= MTDPART_SIZ_FULL,
> +	},
> +};
> 
>  static struct omap_board_config_kernel ti8168_evm_config[] __initdata = {
>  };
> @@ -35,6 +72,8 @@ static void __init ti8168_init_early(void)
> 
>  static void __init ti8168_evm_init(void)
>  {
> +	board_nand_init(ti816x_nand_partitions,
> +		ARRAY_SIZE(ti816x_nand_partitions), 0, NAND_BUSWIDTH_16);
>  	omap_serial_init();
>  	omap_board_config = ti8168_evm_config;
>  	omap_board_config_size = ARRAY_SIZE(ti8168_evm_config);
> --
> 1.6.2.4
Artem Bityutskiy - Sept. 19, 2011, 4:56 a.m.
On Thu, 2011-09-08 at 18:33 +0530, Saxena, Parth wrote:
> Add partition table for NAND device on TI8168 EVM
> and initialise the NAND module.
> 
> Signed-off-by: Saxena, Parth <parth.saxena@ti.com>
> Signed-off-by: Basheer, Mansoor Ahamed <mansoor.ahamed@ti.com>
> ---
> 
> This patch is tested on top of linux-omap/master and
> Hemant's patches submitted recently.
> 
> http://www.mail-archive.com/linux-omap@vger.kernel.org/msg53457.html
> http://www.mail-archive.com/linux-omap@vger.kernel.org/msg54296.html
> 
>  arch/arm/mach-omap2/board-ti8168evm.c |   39 +++++++++++++++++++++++++++++++++
>  1 files changed, 39 insertions(+), 0 deletions(-)

Please, send this patch to Tony, I think it should go in via the omap
tree, not via the MTD tree.
Saxena, Parth - Sept. 19, 2011, 11:34 a.m.
> -----Original Message-----
> From: Artem Bityutskiy [mailto:dedekind1@gmail.com]
> Sent: Monday, September 19, 2011 10:26 AM
> To: Saxena, Parth
> Cc: linux-mtd@lists.infradead.org; Basheer, Mansoor Ahamed; linux-
> omap@vger.kernel.org
> Subject: Re: [PATCH] ti816x: add support for nand on ti8168 evm
> 
> On Thu, 2011-09-08 at 18:33 +0530, Saxena, Parth wrote:
> > Add partition table for NAND device on TI8168 EVM
> > and initialise the NAND module.
> >
> > Signed-off-by: Saxena, Parth <parth.saxena@ti.com>
> > Signed-off-by: Basheer, Mansoor Ahamed <mansoor.ahamed@ti.com>
> > ---
> >
> > This patch is tested on top of linux-omap/master and
> > Hemant's patches submitted recently.
> >
> > http://www.mail-archive.com/linux-omap@vger.kernel.org/msg53457.html
> > http://www.mail-archive.com/linux-omap@vger.kernel.org/msg54296.html
> >
> >  arch/arm/mach-omap2/board-ti8168evm.c |   39
> +++++++++++++++++++++++++++++++++
> >  1 files changed, 39 insertions(+), 0 deletions(-)
> 
> Please, send this patch to Tony, I think it should go in via the omap
> tree, not via the MTD tree.

[Saxena, Parth] 
Artem,
I will re-post this patch to linux-omap list and Tony. Can I add your name in the 'Acked-by' section?
> 
> --
> Best Regards,
> Artem Bityutskiy
Artem Bityutskiy - Sept. 19, 2011, 12:31 p.m.
On Mon, 2011-09-19 at 17:04 +0530, Saxena, Parth wrote:
> Artem,
> I will re-post this patch to linux-omap list and Tony. Can I add your name in the 'Acked-by' section?

No, I did not review this patch.

Patch

diff --git a/arch/arm/mach-omap2/board-ti8168evm.c b/arch/arm/mach-omap2/board-ti8168evm.c
index e516a04..87953bb 100644
--- a/arch/arm/mach-omap2/board-ti8168evm.c
+++ b/arch/arm/mach-omap2/board-ti8168evm.c
@@ -14,6 +14,7 @@ 
  */
 #include <linux/kernel.h>
 #include <linux/init.h>
+#include <linux/mtd/nand.h>
 
 #include <mach/hardware.h>
 #include <asm/mach-types.h>
@@ -23,6 +24,42 @@ 
 #include <plat/irqs.h>
 #include <plat/board.h>
 #include <plat/common.h>
+#include <plat/gpmc.h>
+#include <plat/nand.h>
+
+#include "board-flash.h"
+
+#define NAND_BLOCK_SIZE		SZ_128K
+
+static struct mtd_partition ti816x_nand_partitions[] = {
+/* All the partition sizes are listed in terms of NAND block size */
+	{
+		.name		= "U-Boot",
+		.offset		= 0,			/* Offset = 0x0 */
+		.size		= 18 * NAND_BLOCK_SIZE,
+		.mask_flags	= MTD_WRITEABLE,	/* force read-only */
+	},
+	{
+		.name		= "U-Boot Env",
+		.offset		= MTDPART_OFS_APPEND,	/* Offset = 0x240000 */
+		.size		= 2 * NAND_BLOCK_SIZE,
+	},
+	{
+		.name		= "Kernel",
+		.offset		= MTDPART_OFS_APPEND,	/* Offset = 0x280000 */
+		.size		= 34 * NAND_BLOCK_SIZE,
+	},
+	{
+		.name		= "File System",
+		.offset		= MTDPART_OFS_APPEND,	/* Offset = 0x6C0000 */
+		.size		= 1601 * NAND_BLOCK_SIZE,
+	},
+	{
+		.name		= "Reserved",
+		.offset		= MTDPART_OFS_APPEND,	/* Offset = 0xCEE0000 */
+		.size		= MTDPART_SIZ_FULL,
+	},
+};
 
 static struct omap_board_config_kernel ti8168_evm_config[] __initdata = {
 };
@@ -35,6 +72,8 @@  static void __init ti8168_init_early(void)
 
 static void __init ti8168_evm_init(void)
 {
+	board_nand_init(ti816x_nand_partitions,
+		ARRAY_SIZE(ti816x_nand_partitions), 0, NAND_BUSWIDTH_16);
 	omap_serial_init();
 	omap_board_config = ti8168_evm_config;
 	omap_board_config_size = ARRAY_SIZE(ti8168_evm_config);