| Message ID | 20190730142959.50892-1-yuehaibing@huawei.com |
|---|---|
| State | Accepted |
| Delegated to: | David Miller |
| Headers | show |
| Series | enetc: Fix build error without PHYLIB | expand |
>-----Original Message----- >From: YueHaibing <yuehaibing@huawei.com> >Sent: Tuesday, July 30, 2019 5:30 PM >To: Claudiu Manoil <claudiu.manoil@nxp.com>; davem@davemloft.net >Cc: linux-kernel@vger.kernel.org; netdev@vger.kernel.org; YueHaibing ><yuehaibing@huawei.com> >Subject: [PATCH] enetc: Fix build error without PHYLIB > >If PHYLIB is not set, build enetc will fails: > >drivers/net/ethernet/freescale/enetc/enetc.o: In function `enetc_open': >enetc.c: undefined reference to `phy_disconnect' >enetc.c: undefined reference to `phy_start' >drivers/net/ethernet/freescale/enetc/enetc.o: In function `enetc_close': >enetc.c: undefined reference to `phy_stop' >enetc.c: undefined reference to `phy_disconnect' >drivers/net/ethernet/freescale/enetc/enetc_ethtool.o: undefined reference to >`phy_ethtool_get_link_ksettings' >drivers/net/ethernet/freescale/enetc/enetc_ethtool.o: undefined reference to >`phy_ethtool_set_link_ksettings' >drivers/net/ethernet/freescale/enetc/enetc_mdio.o: In function >`enetc_mdio_probe': >enetc_mdio.c: undefined reference to `mdiobus_alloc_size' >enetc_mdio.c: undefined reference to `mdiobus_free' > >Reported-by: Hulk Robot <hulkci@huawei.com> >Fixes: d4fd0404c1c9 ("enetc: Introduce basic PF and VF ENETC ethernet drivers") >Signed-off-by: YueHaibing <yuehaibing@huawei.com> Acked-by: Claudiu Manoil <claudiu.manoil@nxp.com>
From: YueHaibing <yuehaibing@huawei.com> Date: Tue, 30 Jul 2019 22:29:59 +0800 > If PHYLIB is not set, build enetc will fails: > > drivers/net/ethernet/freescale/enetc/enetc.o: In function `enetc_open': > enetc.c: undefined reference to `phy_disconnect' > enetc.c: undefined reference to `phy_start' > drivers/net/ethernet/freescale/enetc/enetc.o: In function `enetc_close': > enetc.c: undefined reference to `phy_stop' > enetc.c: undefined reference to `phy_disconnect' > drivers/net/ethernet/freescale/enetc/enetc_ethtool.o: undefined reference to `phy_ethtool_get_link_ksettings' > drivers/net/ethernet/freescale/enetc/enetc_ethtool.o: undefined reference to `phy_ethtool_set_link_ksettings' > drivers/net/ethernet/freescale/enetc/enetc_mdio.o: In function `enetc_mdio_probe': > enetc_mdio.c: undefined reference to `mdiobus_alloc_size' > enetc_mdio.c: undefined reference to `mdiobus_free' > > Reported-by: Hulk Robot <hulkci@huawei.com> > Fixes: d4fd0404c1c9 ("enetc: Introduce basic PF and VF ENETC ethernet drivers") > Signed-off-by: YueHaibing <yuehaibing@huawei.com> Applied.
diff --git a/drivers/net/ethernet/freescale/enetc/Kconfig b/drivers/net/ethernet/freescale/enetc/Kconfig index ed0d010..46fdf36b 100644 --- a/drivers/net/ethernet/freescale/enetc/Kconfig +++ b/drivers/net/ethernet/freescale/enetc/Kconfig @@ -2,6 +2,7 @@ config FSL_ENETC tristate "ENETC PF driver" depends on PCI && PCI_MSI && (ARCH_LAYERSCAPE || COMPILE_TEST) + select PHYLIB help This driver supports NXP ENETC gigabit ethernet controller PCIe physical function (PF) devices, managing ENETC Ports at a privileged
If PHYLIB is not set, build enetc will fails: drivers/net/ethernet/freescale/enetc/enetc.o: In function `enetc_open': enetc.c: undefined reference to `phy_disconnect' enetc.c: undefined reference to `phy_start' drivers/net/ethernet/freescale/enetc/enetc.o: In function `enetc_close': enetc.c: undefined reference to `phy_stop' enetc.c: undefined reference to `phy_disconnect' drivers/net/ethernet/freescale/enetc/enetc_ethtool.o: undefined reference to `phy_ethtool_get_link_ksettings' drivers/net/ethernet/freescale/enetc/enetc_ethtool.o: undefined reference to `phy_ethtool_set_link_ksettings' drivers/net/ethernet/freescale/enetc/enetc_mdio.o: In function `enetc_mdio_probe': enetc_mdio.c: undefined reference to `mdiobus_alloc_size' enetc_mdio.c: undefined reference to `mdiobus_free' Reported-by: Hulk Robot <hulkci@huawei.com> Fixes: d4fd0404c1c9 ("enetc: Introduce basic PF and VF ENETC ethernet drivers") Signed-off-by: YueHaibing <yuehaibing@huawei.com> --- drivers/net/ethernet/freescale/enetc/Kconfig | 1 + 1 file changed, 1 insertion(+)