Patchwork [U-Boot,4/6] YAFFS2: fs/yaffs2/yaffs_nand.[hc] - fix build warnings

login
register
mail settings
Submitter Wolfgang Denk
Date Sept. 8, 2011, 12:10 p.m.
Message ID <1315483822-25399-5-git-send-email-wd@denx.de>
Download mbox | patch
Permalink /patch/113898/
State Accepted
Commit fa00e0324cc93e5cffa959718c9cab359ebe6289
Headers show

Comments

Wolfgang Denk - Sept. 8, 2011, 12:10 p.m.
Fix these:
yaffs_guts.c: In function 'yaffs_Scan':
yaffs_guts.c:5436: warning: pointer targets in passing argument 4 of 'yaffs_QueryInitialBlockState' differ in signedness
yaffs_guts.c: In function 'yaffs_ScanBackwards':
yaffs_guts.c:6017: warning: pointer targets in passing argument 4 of 'yaffs_QueryInitialBlockState' differ in signedness
yaffs_nand.c: In function 'yaffs_QueryInitialBlockState':
yaffs_nand.c:109: warning: pointer targets in passing argument 4 of 'dev->queryNANDBlock' differ in signedness
yaffs_nand.c:113: warning: pointer targets in passing argument 4 of 'yaffs_TagsCompatabilityQueryNANDBlock' differ in signedness

Signed-off-by: Wolfgang Denk <wd@denx.de>
---
 fs/yaffs2/yaffs_nand.c |    2 +-
 fs/yaffs2/yaffs_nand.h |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
Wolfgang Denk - Sept. 9, 2011, 10:01 p.m.
Dear Wolfgang Denk,

In message <1315483822-25399-5-git-send-email-wd@denx.de> you wrote:
> Fix these:
> yaffs_guts.c: In function 'yaffs_Scan':
> yaffs_guts.c:5436: warning: pointer targets in passing argument 4 of 'yaffs_QueryInitialBlockState' differ in signedness
> yaffs_guts.c: In function 'yaffs_ScanBackwards':
> yaffs_guts.c:6017: warning: pointer targets in passing argument 4 of 'yaffs_QueryInitialBlockState' differ in signedness
> yaffs_nand.c: In function 'yaffs_QueryInitialBlockState':
> yaffs_nand.c:109: warning: pointer targets in passing argument 4 of 'dev->queryNANDBlock' differ in signedness
> yaffs_nand.c:113: warning: pointer targets in passing argument 4 of 'yaffs_TagsCompatabilityQueryNANDBlock' differ in signedness
> 
> Signed-off-by: Wolfgang Denk <wd@denx.de>
> ---
>  fs/yaffs2/yaffs_nand.c |    2 +-
>  fs/yaffs2/yaffs_nand.h |    2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)

Applied, thanks.

Best regards,

Wolfgang Denk

Patch

diff --git a/fs/yaffs2/yaffs_nand.c b/fs/yaffs2/yaffs_nand.c
index e790be6..ce048cc 100644
--- a/fs/yaffs2/yaffs_nand.c
+++ b/fs/yaffs2/yaffs_nand.c
@@ -101,7 +101,7 @@  int yaffs_MarkBlockBad(yaffs_Device * dev, int blockNo)
 int yaffs_QueryInitialBlockState(yaffs_Device * dev,
 						 int blockNo,
 						 yaffs_BlockState * state,
-						 unsigned *sequenceNumber)
+						 int *sequenceNumber)
 {
 	blockNo -= dev->blockOffset;
 
diff --git a/fs/yaffs2/yaffs_nand.h b/fs/yaffs2/yaffs_nand.h
index 48e3f7e..f3bedcf 100644
--- a/fs/yaffs2/yaffs_nand.h
+++ b/fs/yaffs2/yaffs_nand.h
@@ -33,7 +33,7 @@  int yaffs_MarkBlockBad(yaffs_Device * dev, int blockNo);
 int yaffs_QueryInitialBlockState(yaffs_Device * dev,
 						 int blockNo,
 						 yaffs_BlockState * state,
-						 unsigned *sequenceNumber);
+						 int *sequenceNumber);
 
 int yaffs_EraseBlockInNAND(struct yaffs_DeviceStruct *dev,
 				  int blockInNAND);