Patchwork [U-Boot] smc911x: Fix build warnings

login
register
mail settings
Submitter Wolfgang Denk
Date Sept. 8, 2011, 11:04 a.m.
Message ID <1315479867-23506-1-git-send-email-wd@denx.de>
Download mbox | patch
Permalink /patch/113890/
State Accepted
Commit 24e1664472deef23abb3246da8573ddefc0c7971
Headers show

Comments

Wolfgang Denk - Sept. 8, 2011, 11:04 a.m.
Commit 6af1d41 "smc911x MII made available" was missing a few "const"
qualifiers.  Fix the resulting in build warnings:

smc911x.c: In function 'smc911x_initialize':
smc911x.c:297: warning: passing argument 2 of 'miiphy_register' from incompatible pointer type
smc911x.c:297: warning: passing argument 3 of 'miiphy_register' from incompatible pointer type

Signed-off-by: Wolfgang Denk <wd@denx.de>
Cc: Helmut Raiger <helmut.raiger@hale.at>
---
 drivers/net/smc911x.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
Wolfgang Denk - Sept. 9, 2011, 9:57 p.m.
Dear Wolfgang Denk,

In message <1315479867-23506-1-git-send-email-wd@denx.de> you wrote:
> Commit 6af1d41 "smc911x MII made available" was missing a few "const"
> qualifiers.  Fix the resulting in build warnings:
> 
> smc911x.c: In function 'smc911x_initialize':
> smc911x.c:297: warning: passing argument 2 of 'miiphy_register' from incompatible pointer type
> smc911x.c:297: warning: passing argument 3 of 'miiphy_register' from incompatible pointer type
> 
> Signed-off-by: Wolfgang Denk <wd@denx.de>
> Cc: Helmut Raiger <helmut.raiger@hale.at>
> ---
>  drivers/net/smc911x.c |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)

Applied, thanks.

Best regards,

Wolfgang Denk

Patch

diff --git a/drivers/net/smc911x.c b/drivers/net/smc911x.c
index 6cc236c..a677fd4 100644
--- a/drivers/net/smc911x.c
+++ b/drivers/net/smc911x.c
@@ -237,7 +237,7 @@  static int smc911x_rx(struct eth_device *dev)
 
 #if defined(CONFIG_MII) || defined(CONFIG_CMD_MII)
 /* wrapper for smc911x_eth_phy_read */
-static int smc911x_miiphy_read(char *devname, u8 phy, u8 reg, u16 *val)
+static int smc911x_miiphy_read(const char *devname, u8 phy, u8 reg, u16 *val)
 {
 	struct eth_device *dev = eth_get_dev_by_name(devname);
 	if (dev)
@@ -245,7 +245,7 @@  static int smc911x_miiphy_read(char *devname, u8 phy, u8 reg, u16 *val)
 	return -1;
 }
 /* wrapper for smc911x_eth_phy_write */
-static int smc911x_miiphy_write(char *devname, u8 phy, u8 reg, u16 val)
+static int smc911x_miiphy_write(const char *devname, u8 phy, u8 reg, u16 val)
 {
 	struct eth_device *dev = eth_get_dev_by_name(devname);
 	if (dev)