Patchwork pci: Remove unused pci_reserve_capability

login
register
mail settings
Submitter Jan Kiszka
Date Sept. 8, 2011, 10:44 a.m.
Message ID <4E689C9F.3070000@siemens.com>
Download mbox | patch
Permalink /patch/113888/
State New
Headers show

Comments

Jan Kiszka - Sept. 8, 2011, 10:44 a.m.
eepro100 was the last user. Now pci_add_capability is powerful enough.

Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
---
 hw/pci.c |    6 ------
 hw/pci.h |    2 --
 2 files changed, 0 insertions(+), 8 deletions(-)
Michael S. Tsirkin - Sept. 9, 2011, 5:01 a.m.
On Thu, Sep 08, 2011 at 12:44:47PM +0200, Jan Kiszka wrote:
> eepro100 was the last user. Now pci_add_capability is powerful enough.
> 
> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>

Applied, thanks.

> ---
>  hw/pci.c |    6 ------
>  hw/pci.h |    2 --
>  2 files changed, 0 insertions(+), 8 deletions(-)
> 
> diff --git a/hw/pci.c b/hw/pci.c
> index 57ff7b1..63c346d 100644
> --- a/hw/pci.c
> +++ b/hw/pci.c
> @@ -2028,12 +2028,6 @@ void pci_del_capability(PCIDevice *pdev, uint8_t cap_id, uint8_t size)
>          pdev->config[PCI_STATUS] &= ~PCI_STATUS_CAP_LIST;
>  }
>  
> -/* Reserve space for capability at a known offset (to call after load). */
> -void pci_reserve_capability(PCIDevice *pdev, uint8_t offset, uint8_t size)
> -{
> -    memset(pdev->used + offset, 0xff, size);
> -}
> -
>  uint8_t pci_find_capability(PCIDevice *pdev, uint8_t cap_id)
>  {
>      return pci_find_capability_list(pdev, cap_id, NULL);
> diff --git a/hw/pci.h b/hw/pci.h
> index 391217e..f2dae63 100644
> --- a/hw/pci.h
> +++ b/hw/pci.h
> @@ -209,8 +209,6 @@ int pci_add_capability(PCIDevice *pdev, uint8_t cap_id,
>  
>  void pci_del_capability(PCIDevice *pci_dev, uint8_t cap_id, uint8_t cap_size);
>  
> -void pci_reserve_capability(PCIDevice *pci_dev, uint8_t offset, uint8_t size);
> -
>  uint8_t pci_find_capability(PCIDevice *pci_dev, uint8_t cap_id);
>  
>  
> -- 
> 1.7.3.4

Patch

diff --git a/hw/pci.c b/hw/pci.c
index 57ff7b1..63c346d 100644
--- a/hw/pci.c
+++ b/hw/pci.c
@@ -2028,12 +2028,6 @@  void pci_del_capability(PCIDevice *pdev, uint8_t cap_id, uint8_t size)
         pdev->config[PCI_STATUS] &= ~PCI_STATUS_CAP_LIST;
 }
 
-/* Reserve space for capability at a known offset (to call after load). */
-void pci_reserve_capability(PCIDevice *pdev, uint8_t offset, uint8_t size)
-{
-    memset(pdev->used + offset, 0xff, size);
-}
-
 uint8_t pci_find_capability(PCIDevice *pdev, uint8_t cap_id)
 {
     return pci_find_capability_list(pdev, cap_id, NULL);
diff --git a/hw/pci.h b/hw/pci.h
index 391217e..f2dae63 100644
--- a/hw/pci.h
+++ b/hw/pci.h
@@ -209,8 +209,6 @@  int pci_add_capability(PCIDevice *pdev, uint8_t cap_id,
 
 void pci_del_capability(PCIDevice *pci_dev, uint8_t cap_id, uint8_t cap_size);
 
-void pci_reserve_capability(PCIDevice *pci_dev, uint8_t offset, uint8_t size);
-
 uint8_t pci_find_capability(PCIDevice *pci_dev, uint8_t cap_id);