Patchwork [1/2] build: fix missing trace dep on GENERATED_HEADERS

login
register
mail settings
Submitter Michael Roth
Date Sept. 7, 2011, 11:40 p.m.
Message ID <1315438852-18029-1-git-send-email-mdroth@linux.vnet.ibm.com>
Download mbox | patch
Permalink /patch/113849/
State New
Headers show

Comments

Michael Roth - Sept. 7, 2011, 11:40 p.m.
fc764105 added an include for qemu-common.h to trace/control.h, which
made all users of this header file dependent on GENERATED_HEADERS. Since
it's used by pretty much all the trace backends now, make trace-obj-y
dependent on GENERATED_HEADERS.

Signed-off-by: Michael Roth <mdroth@linux.vnet.ibm.com>
---
 Makefile.objs |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)
Stefan Hajnoczi - Sept. 8, 2011, 9:35 a.m.
On Thu, Sep 8, 2011 at 12:40 AM, Michael Roth <mdroth@linux.vnet.ibm.com> wrote:
> fc764105 added an include for qemu-common.h to trace/control.h, which
> made all users of this header file dependent on GENERATED_HEADERS. Since
> it's used by pretty much all the trace backends now, make trace-obj-y
> dependent on GENERATED_HEADERS.
>
> Signed-off-by: Michael Roth <mdroth@linux.vnet.ibm.com>
> ---
>  Makefile.objs |    2 ++
>  1 files changed, 2 insertions(+), 0 deletions(-)

Reviewed-by: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>

Patch

diff --git a/Makefile.objs b/Makefile.objs
index 26b885b..a529a11 100644
--- a/Makefile.objs
+++ b/Makefile.objs
@@ -390,6 +390,8 @@  trace-nested-y += control.o
 
 trace-obj-y += $(addprefix trace/, $(trace-nested-y))
 
+$(trace-obj-y): $(GENERATED_HEADERS)
+
 ######################################################################
 # smartcard