Patchwork [BUG] ext3: cannot unfreeze a filesystem due to a deadlock

login
register
mail settings
Submitter Greg Freemyer
Date Sept. 7, 2011, 4:45 p.m.
Message ID <CAGpXXZL=+K0ETvM0kGE6zqe3pB7AS_exU+dCbpm+uUSG2JJ+0A@mail.gmail.com>
Download mbox | patch
Permalink /patch/113797/
State New
Headers show

Comments

Greg Freemyer - Sept. 7, 2011, 4:45 p.m.
On Wed, Sep 7, 2011 at 2:40 AM, Christoph Hellwig <hch@infradead.org> wrote:
> On Wed, Sep 07, 2011 at 12:29:30PM +0900, Masayoshi MIZUMA wrote:
>> Hi,
>>
>> When I checked the freeze feature for ext3 filesystem using fsfreeze
>> command at 3.1.0-rc4, I think the following deadlock problem happened.
>>
>> How to reproduce:
>>  # mkfs -t ext3 /dev/sdd1
>>  # mount /dev/sdd1 /MNT
>>  # ./fsstress -d /MNT/tmp -n 10 -p 1000 > /dev/null 2>&1 &
>>  # fsfreeze -f /MNT
>>  # fsfreeze -u /MNT
>
> Can you add this testcase to xfstests?

Christoph,

Isn't that just a matter of extending test 068 to ext4

====

That's a totally untested patch if someone wants to try it.

Greg
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Eric Sandeen - Sept. 7, 2011, 5:10 p.m.
On 9/7/11 11:50 AM, Christoph Hellwig wrote:
> On Wed, Sep 07, 2011 at 12:45:34PM -0400, Greg Freemyer wrote:
>>> Can you add this testcase to xfstests?
>>
>> Christoph,
>>
>> Isn't that just a matter of extending test 068 to ext4
> 
> If you have recent enough xfsprogs that allow the freeze command
> for foreign filesystems that might work. 

where "recent enough" is since Tue Feb 10 14:41:51 2009 -0600

I say go for it :)

Could always add a quick helper to make sure the xfs_io command
doesn't fail on freeze, and _notrun if it does.

-Eric

--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Christoph Hellwig - Sept. 7, 2011, 5:17 p.m.
On Wed, Sep 07, 2011 at 12:10:07PM -0500, Eric Sandeen wrote:
> > If you have recent enough xfsprogs that allow the freeze command
> > for foreign filesystems that might work. 
> 
> where "recent enough" is since Tue Feb 10 14:41:51 2009 -0600
> 
> I say go for it :)
> 
> Could always add a quick helper to make sure the xfs_io command
> doesn't fail on freeze, and _notrun if it does.

With the _notrun trick it could probably even claim generic fs
support.

--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

====
--- 068 2011-06-30 18:41:17.000000000 -0400
+++ 068.new     2011-09-07 12:41:35.000000000 -0400
@@ -51,7 +51,7 @@ 
 . ./common.filter

 # real QA test starts here
-_supported_fs xfs
+_supported_fs xfs ext3 ext4
 _supported_os Linux IRIX

 _require_scratch