From patchwork Wed Sep 7 15:45:35 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bernd Schmidt X-Patchwork-Id: 113777 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) by ozlabs.org (Postfix) with SMTP id 67F0EB6F81 for ; Thu, 8 Sep 2011 01:48:02 +1000 (EST) Received: (qmail 31453 invoked by alias); 7 Sep 2011 15:47:59 -0000 Received: (qmail 31444 invoked by uid 22791); 7 Sep 2011 15:47:58 -0000 X-SWARE-Spam-Status: No, hits=1.1 required=5.0 tests=AWL, BAYES_00, BOTNET, RDNS_NONE X-Spam-Check-By: sourceware.org Received: from Unknown (HELO mail.codesourcery.com) (38.113.113.100) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 07 Sep 2011 15:47:42 +0000 Received: (qmail 21525 invoked from network); 7 Sep 2011 15:47:41 -0000 Received: from unknown (HELO ?84.152.220.73?) (bernds@127.0.0.2) by mail.codesourcery.com with ESMTPA; 7 Sep 2011 15:47:41 -0000 Message-ID: <4E67919F.3090204@codesourcery.com> Date: Wed, 07 Sep 2011 17:45:35 +0200 From: Bernd Schmidt User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.2.20) Gecko/20110905 Lightning/1.0b3pre Thunderbird/3.1.12 MIME-Version: 1.0 To: Richard Henderson , GCC Patches , richard.sandiford@linaro.org Subject: Re: Add unwind information to mips epilogues References: <4E5E6E6D.8050905@codesourcery.com> <87zkipl8uv.fsf@firetop.home> <4E642AF3.2020706@redhat.com> <4E6593EF.6000101@redhat.com> <4E67474E.1070106@codesourcery.com> In-Reply-To: <4E67474E.1070106@codesourcery.com> Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Testing with the shrink-wrapping patch added reveals a problem with the mips16 "save" insn: sometimes we store registers that shouldn't be considered saved registers; we have to clear RTX_FRAME_RELATED_P for these. Testing in progress with mips-elf, "ips16/arch=mips32r2/abi=32" and some other multilibs. Ok? Bernd * config/mips/mips.c (mips16e_build_save_restore): Clear RTX_FRAME_RELATED_P for argument stores stolen from the first block. Index: gcc/config/mips/mips.c =================================================================== --- gcc/config/mips/mips.c (revision 178135) +++ gcc/config/mips/mips.c (working copy) @@ -8448,6 +8456,7 @@ mips16e_build_save_restore (bool restore offset = top_offset + i * UNITS_PER_WORD; set = mips16e_save_restore_reg (restore_p, offset, GP_ARG_FIRST + i); XVECEXP (pattern, 0, n++) = set; + RTX_FRAME_RELATED_P (set) = 0; } /* Then fill in the other register moves. */