| Message ID | 20190726053959.2003-15-andrew@aj.id.au |
|---|---|
| State | Changes Requested, archived |
| Headers | show |
| Series | Clean up ASPEED devicetree warnings | expand |
在 2019-07-26 13:39, Andrew Jeffery 写道: > The currently interrupts are configured after the channel was enabled. > > Cc: Haiyue Wang<haiyue.wang@linux.intel.com> > Cc: Corey Minyard<minyard@acm.org> > Cc: Arnd Bergmann<arnd@arndb.de> > Cc: Greg Kroah-Hartman<gregkh@linuxfoundation.org> > Cc:openipmi-developer@lists.sourceforge.net > Signed-off-by: Andrew Jeffery<andrew@aj.id.au> > --- > drivers/char/ipmi/kcs_bmc_aspeed.c | 7 ++++--- > 1 file changed, 4 insertions(+), 3 deletions(-) > > diff --git a/drivers/char/ipmi/kcs_bmc_aspeed.c b/drivers/char/ipmi/kcs_bmc_aspeed.c > index 3c955946e647..e3dd09022589 100644 > --- a/drivers/char/ipmi/kcs_bmc_aspeed.c > +++ b/drivers/char/ipmi/kcs_bmc_aspeed.c > @@ -268,13 +268,14 @@ static int aspeed_kcs_probe(struct platform_device *pdev) > kcs_bmc->io_inputb = aspeed_kcs_inb; > kcs_bmc->io_outputb = aspeed_kcs_outb; > > + rc = aspeed_kcs_config_irq(kcs_bmc, pdev); > + if (rc) > + return rc; > + > dev_set_drvdata(dev, kcs_bmc); Thanks for catching this, for not miss the data.
在 2019-07-27 01:04, Wang, Haiyue 写道: > 在 2019-07-26 13:39, Andrew Jeffery 写道: >> The currently interrupts are configured after the channel was enabled. >> >> Cc: Haiyue Wang<haiyue.wang@linux.intel.com> >> Cc: Corey Minyard<minyard@acm.org> >> Cc: Arnd Bergmann<arnd@arndb.de> >> Cc: Greg Kroah-Hartman<gregkh@linuxfoundation.org> >> Cc:openipmi-developer@lists.sourceforge.net >> Signed-off-by: Andrew Jeffery<andrew@aj.id.au> >> --- >> drivers/char/ipmi/kcs_bmc_aspeed.c | 7 ++++--- >> 1 file changed, 4 insertions(+), 3 deletions(-) >> >> diff --git a/drivers/char/ipmi/kcs_bmc_aspeed.c >> b/drivers/char/ipmi/kcs_bmc_aspeed.c >> index 3c955946e647..e3dd09022589 100644 >> --- a/drivers/char/ipmi/kcs_bmc_aspeed.c >> +++ b/drivers/char/ipmi/kcs_bmc_aspeed.c >> @@ -268,13 +268,14 @@ static int aspeed_kcs_probe(struct >> platform_device *pdev) >> kcs_bmc->io_inputb = aspeed_kcs_inb; >> kcs_bmc->io_outputb = aspeed_kcs_outb; >> + rc = aspeed_kcs_config_irq(kcs_bmc, pdev); >> + if (rc) >> + return rc; >> + >> dev_set_drvdata(dev, kcs_bmc); > > > Thanks for catching this, for not miss the data. > Reviewed-by: Haiyue Wang <haiyue.wang@linux.intel.com>
diff --git a/drivers/char/ipmi/kcs_bmc_aspeed.c b/drivers/char/ipmi/kcs_bmc_aspeed.c index 3c955946e647..e3dd09022589 100644 --- a/drivers/char/ipmi/kcs_bmc_aspeed.c +++ b/drivers/char/ipmi/kcs_bmc_aspeed.c @@ -268,13 +268,14 @@ static int aspeed_kcs_probe(struct platform_device *pdev) kcs_bmc->io_inputb = aspeed_kcs_inb; kcs_bmc->io_outputb = aspeed_kcs_outb; + rc = aspeed_kcs_config_irq(kcs_bmc, pdev); + if (rc) + return rc; + dev_set_drvdata(dev, kcs_bmc); aspeed_kcs_set_address(kcs_bmc, addr); aspeed_kcs_enable_channel(kcs_bmc, true); - rc = aspeed_kcs_config_irq(kcs_bmc, pdev); - if (rc) - return rc; rc = misc_register(&kcs_bmc->miscdev); if (rc) {
The currently interrupts are configured after the channel was enabled. Cc: Haiyue Wang <haiyue.wang@linux.intel.com> Cc: Corey Minyard <minyard@acm.org> Cc: Arnd Bergmann <arnd@arndb.de> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> Cc: openipmi-developer@lists.sourceforge.net Signed-off-by: Andrew Jeffery <andrew@aj.id.au> --- drivers/char/ipmi/kcs_bmc_aspeed.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-)