| Message ID | 20190725102648.13445-2-jank@cadence.com |
|---|---|
| State | Changes Requested, archived |
| Headers | show |
| Series | media: Add support for Cadence CSI2RX version 2.1 | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success |
On Thu, Jul 25, 2019 at 11:26:46AM +0100, Jan Kotas wrote: > This patch adds a DT bindings documentation for > Cadence CSI2RX v2.1 controller. And 1.3? > > Signed-off-by: Jan Kotas <jank@cadence.com> > --- > Documentation/devicetree/bindings/media/cdns,csi2rx.txt | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/media/cdns,csi2rx.txt b/Documentation/devicetree/bindings/media/cdns,csi2rx.txt > index 6b02a0657..a35bb0aed 100644 > --- a/Documentation/devicetree/bindings/media/cdns,csi2rx.txt > +++ b/Documentation/devicetree/bindings/media/cdns,csi2rx.txt > @@ -5,7 +5,9 @@ The Cadence MIPI-CSI2 RX controller is a CSI-2 bridge supporting up to 4 CSI > lanes in input, and 4 different pixel streams in output. > > Required properties: > - - compatible: must be set to "cdns,csi2rx" and an SoC-specific compatible > + - compatible: must be set to "cdns,csi2rx" or "cdns,csi2rx-1.3" > + for version 1.3 of the controller, "cdns,csi2rx-2.1" for v2.1 > + and an SoC-specific compatible This wording is now not clear that an SoC-specific compatible is always required or just for 2.1. Please format one compatible per line. > - reg: base address and size of the memory mapped region > - clocks: phandles to the clocks driving the controller > - clock-names: must contain: > -- > 2.15.0 >
> On 16 Aug 2019, at 23:18, Rob Herring <robh@kernel.org> wrote: > > > On Thu, Jul 25, 2019 at 11:26:46AM +0100, Jan Kotas wrote: >> This patch adds a DT bindings documentation for >> Cadence CSI2RX v2.1 controller. > > And 1.3? OK, I’ll update the commit description. >> Required properties: >> - - compatible: must be set to "cdns,csi2rx" and an SoC-specific compatible >> + - compatible: must be set to "cdns,csi2rx" or "cdns,csi2rx-1.3" >> + for version 1.3 of the controller, "cdns,csi2rx-2.1" for v2.1 >> + and an SoC-specific compatible > > This wording is now not clear that an SoC-specific compatible is always > required or just for 2.1. Please format one compatible per line. OK, I will fix it in v2. Thank you for the comments. Regards, Jan
diff --git a/Documentation/devicetree/bindings/media/cdns,csi2rx.txt b/Documentation/devicetree/bindings/media/cdns,csi2rx.txt index 6b02a0657..a35bb0aed 100644 --- a/Documentation/devicetree/bindings/media/cdns,csi2rx.txt +++ b/Documentation/devicetree/bindings/media/cdns,csi2rx.txt @@ -5,7 +5,9 @@ The Cadence MIPI-CSI2 RX controller is a CSI-2 bridge supporting up to 4 CSI lanes in input, and 4 different pixel streams in output. Required properties: - - compatible: must be set to "cdns,csi2rx" and an SoC-specific compatible + - compatible: must be set to "cdns,csi2rx" or "cdns,csi2rx-1.3" + for version 1.3 of the controller, "cdns,csi2rx-2.1" for v2.1 + and an SoC-specific compatible - reg: base address and size of the memory mapped region - clocks: phandles to the clocks driving the controller - clock-names: must contain:
This patch adds a DT bindings documentation for Cadence CSI2RX v2.1 controller. Signed-off-by: Jan Kotas <jank@cadence.com> --- Documentation/devicetree/bindings/media/cdns,csi2rx.txt | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)