Patchwork Ensure we actually allow UDMA/100

login
register
mail settings
Submitter Dan McGee
Date Sept. 6, 2011, 8:45 p.m.
Message ID <1315341922-10286-1-git-send-email-dpmcgee@gmail.com>
Download mbox | patch
Permalink /patch/113665/
State Not Applicable
Delegated to: David Miller
Headers show

Comments

Dan McGee - Sept. 6, 2011, 8:45 p.m.
We were limiting to UDMA/66 instead.
---
Jeff,

Can this get folded in? Just realized the bitmask I used from Alan's patch wasn't right as it didn't actually allow UDMA/100, it was setting the max at UDMA/66. This simple fixup has been boot tested.

-Dan

 drivers/ata/pata_sis.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

Patch

diff --git a/drivers/ata/pata_sis.c b/drivers/ata/pata_sis.c
index 54c41c7..810b7d6 100644
--- a/drivers/ata/pata_sis.c
+++ b/drivers/ata/pata_sis.c
@@ -526,7 +526,7 @@  static unsigned long sis_133_mode_filter(struct ata_device *adev, unsigned long
 	pci_read_config_dword(pdev, port, &t1);
 	/* if ATA133 is disabled, mask it out */
 	if (!(t1 & 0x08))
-		mask &= ~(0xE0 << ATA_SHIFT_UDMA);
+		mask &= ~(0xC0 << ATA_SHIFT_UDMA);
 	return mask;
 }