Patchwork usb: Owen SI-30 support

login
register
mail settings
Submitter Denis Pershin
Date Sept. 6, 2011, 1:49 a.m.
Message ID <4E657C24.3040503@perchine.com>
Download mbox | patch
Permalink /patch/113601/
State New
Headers show

Comments

Denis Pershin - Sept. 6, 2011, 1:49 a.m.
Hello,

please, include this patch in Ubuntu kernel.
Patch should apply on all kernels from 2.6.x to 3.0.x
Actually this patch was tested as a patch against Ubuntu 10.10 kernel  
2.6.35-25-generic-pae

--
Denis Pershin
CTO of Navitel

-------- Исходное сообщение --------
Тема: 	[PATCH] usb: Owen SI-30 support
Дата: 	Sun, 04 Sep 2011 17:37:21 +0700
От: 	Denis Pershin <dyp@perchine.com>
Кому: 	Oliver Neukum <oliver@neukum.name>, Greg Kroah-Hartman 
<gregkh@suse.de>, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org



Hello,

here it is the patch to support Owen SI-30 device.
This is a pulse counter controller.
http://www.owen.ru/en/catalog/93788515

usb-drivers output:
T:  Bus=01 Lev=01 Prnt=01 Port=00 Cnt=01 Dev#=  4 Spd=12  MxCh= 0
D:  Ver= 2.00 Cls=02(commc) Sub=00 Prot=00 MxPS= 8 #Cfgs=  1
P:  Vendor=03eb ProdID=0030 Rev=01.01
C:  #Ifs= 2 Cfg#= 1 Atr=c0 MxPwr=0mA
I:  If#= 0 Alt= 0 #EPs= 1 Cls=02(commc) Sub=02 Prot=00 Driver=cdc_acm
I:  If#= 1 Alt= 0 #EPs= 2 Cls=0a(data ) Sub=00 Prot=00 Driver=cdc_acm

Patch is made against 3.0.4 from kernel git.
This patch is installed on my home system which receives data from this
controller connected to cold water counter.
It works well for more than 6 monthes. Please, include this patch to
mainstream.

Signed-off-by: Denis Pershin<dyp@perchine.com>


      /* Support Lego NXT using pbLua firmware */

--
Denis Pershin
CTO of Navitel
Leann Ogasawara - Sept. 6, 2011, 5:30 p.m.
On Tue, 2011-09-06 at 08:49 +0700, Denis Pershin wrote:
> Hello,
> 
> please, include this patch in Ubuntu kernel.
> Patch should apply on all kernels from 2.6.x to 3.0.x
> Actually this patch was tested as a patch against Ubuntu 10.10 kernel
> 2.6.35-25-generic-pae
> 
> --
> Denis Pershin
> CTO of Navitel
> 
> -------- Исходное сообщение -------- 
>                              Тема: 
> [PATCH] usb: Owen SI-30 support
>                              Дата: 
> Sun, 04 Sep 2011 17:37:21 +0700
>                                От: 
> Denis Pershin <dyp@perchine.com>
>                              Кому: 
> Oliver Neukum <oliver@neukum.name>,
> Greg Kroah-Hartman
> <gregkh@suse.de>,
> linux-usb@vger.kernel.org,
> linux-kernel@vger.kernel.org
> 
> 
> Hello,
> 
> here it is the patch to support Owen SI-30 device.
> This is a pulse counter controller.
> http://www.owen.ru/en/catalog/93788515
> 
> usb-drivers output:
> T:  Bus=01 Lev=01 Prnt=01 Port=00 Cnt=01 Dev#=  4 Spd=12  MxCh= 0
> D:  Ver= 2.00 Cls=02(commc) Sub=00 Prot=00 MxPS= 8 #Cfgs=  1
> P:  Vendor=03eb ProdID=0030 Rev=01.01
> C:  #Ifs= 2 Cfg#= 1 Atr=c0 MxPwr=0mA
> I:  If#= 0 Alt= 0 #EPs= 1 Cls=02(commc) Sub=02 Prot=00 Driver=cdc_acm
> I:  If#= 1 Alt= 0 #EPs= 2 Cls=0a(data ) Sub=00 Prot=00 Driver=cdc_acm
> 
> Patch is made against 3.0.4 from kernel git.
> This patch is installed on my home system which receives data from this 
> controller connected to cold water counter.
> It works well for more than 6 monthes. Please, include this patch to 
> mainstream.
> 
> Signed-off-by: Denis Pershin<dyp@perchine.com>
> 
> 
> diff --git a/drivers/usb/class/cdc-acm.c b/drivers/usb/class/cdc-acm.c
> index dac7676..5112f57 100644
> --- a/drivers/usb/class/cdc-acm.c
> +++ b/drivers/usb/class/cdc-acm.c
> @@ -1534,6 +1534,9 @@ static const struct usb_device_id acm_ids[] = {
>      { NOKIA_PCSUITE_ACM_INFO(0x03cd), }, /* Nokia C7 */
>      { SAMSUNG_PCSUITE_ACM_INFO(0x6651), }, /* Samsung GTi8510 (INNOV8) */
> 
> +    /* Support for Owen devices */
> +    { USB_DEVICE(0x03eb, 0x0030), }, /* Owen SI30 */
> +
>      /* NOTE: non-Nokia COMM/ACM/0xff is likely MSFT RNDIS... NOT a 
> modem! */
> 
>      /* Support Lego NXT using pbLua firmware */
> 
> --
> Denis Pershin
> CTO of Navitel
> 

Hi Denis,

It's probably best for you to submit this to upstream stable [1] once
it's been applied to Linus' tree.  That way we'll pick this up
automatically when we rebase to upstream stable.

Thanks,
Leann

[1] http://git.kernel.org/?p=linux/kernel/git/torvalds/linux.git;a=blob;f=Documentation/stable_kernel_rules.txt

Patch

diff --git a/drivers/usb/class/cdc-acm.c b/drivers/usb/class/cdc-acm.c
index dac7676..5112f57 100644
--- a/drivers/usb/class/cdc-acm.c
+++ b/drivers/usb/class/cdc-acm.c
@@ -1534,6 +1534,9 @@  static const struct usb_device_id acm_ids[] = {
      { NOKIA_PCSUITE_ACM_INFO(0x03cd), }, /* Nokia C7 */
      { SAMSUNG_PCSUITE_ACM_INFO(0x6651), }, /* Samsung GTi8510 (INNOV8) */

+    /* Support for Owen devices */
+    { USB_DEVICE(0x03eb, 0x0030), }, /* Owen SI30 */
+
      /* NOTE: non-Nokia COMM/ACM/0xff is likely MSFT RNDIS... NOT a
modem! */