| Message ID | 20190723083923.21392-1-hslester96@gmail.com |
|---|---|
| State | New |
| Headers | show |
| Series | [v2] gpio: pch: Use dev_get_drvdata | expand |
wt., 23 lip 2019 o 10:39 Chuhong Yuan <hslester96@gmail.com> napisał(a): > > Instead of using to_pci_dev + pci_get_drvdata, > use dev_get_drvdata to make code simpler. > > Signed-off-by: Chuhong Yuan <hslester96@gmail.com> > --- > Changes in v2: > - Change the subject line to gpio: pch: ... > > drivers/gpio/gpio-pch.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/drivers/gpio/gpio-pch.c b/drivers/gpio/gpio-pch.c > index 1d99293096f2..3f3d9a94b709 100644 > --- a/drivers/gpio/gpio-pch.c > +++ b/drivers/gpio/gpio-pch.c > @@ -409,8 +409,7 @@ static int pch_gpio_probe(struct pci_dev *pdev, > > static int __maybe_unused pch_gpio_suspend(struct device *dev) > { > - struct pci_dev *pdev = to_pci_dev(dev); > - struct pch_gpio *chip = pci_get_drvdata(pdev); > + struct pch_gpio *chip = dev_get_drvdata(dev); > unsigned long flags; > > spin_lock_irqsave(&chip->spinlock, flags); > @@ -422,8 +421,7 @@ static int __maybe_unused pch_gpio_suspend(struct device *dev) > > static int __maybe_unused pch_gpio_resume(struct device *dev) > { > - struct pci_dev *pdev = to_pci_dev(dev); > - struct pch_gpio *chip = pci_get_drvdata(pdev); > + struct pch_gpio *chip = dev_get_drvdata(dev); > unsigned long flags; > > spin_lock_irqsave(&chip->spinlock, flags); > -- > 2.20.1 > Acked-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
On Tue, Jul 23, 2019 at 11:49:46AM +0200, Bartosz Golaszewski wrote: > wt., 23 lip 2019 o 10:39 Chuhong Yuan <hslester96@gmail.com> napisał(a): > > > > Instead of using to_pci_dev + pci_get_drvdata, > > use dev_get_drvdata to make code simpler. > > > > Signed-off-by: Chuhong Yuan <hslester96@gmail.com> > > --- > > Changes in v2: > > - Change the subject line to gpio: pch: ... > > > > drivers/gpio/gpio-pch.c | 6 ++---- > > 1 file changed, 2 insertions(+), 4 deletions(-) > > > > diff --git a/drivers/gpio/gpio-pch.c b/drivers/gpio/gpio-pch.c > > index 1d99293096f2..3f3d9a94b709 100644 > > --- a/drivers/gpio/gpio-pch.c > > +++ b/drivers/gpio/gpio-pch.c > > @@ -409,8 +409,7 @@ static int pch_gpio_probe(struct pci_dev *pdev, > > > > static int __maybe_unused pch_gpio_suspend(struct device *dev) > > { > > - struct pci_dev *pdev = to_pci_dev(dev); > > - struct pch_gpio *chip = pci_get_drvdata(pdev); > > + struct pch_gpio *chip = dev_get_drvdata(dev); > > unsigned long flags; > > > > spin_lock_irqsave(&chip->spinlock, flags); > > @@ -422,8 +421,7 @@ static int __maybe_unused pch_gpio_suspend(struct device *dev) > > > > static int __maybe_unused pch_gpio_resume(struct device *dev) > > { > > - struct pci_dev *pdev = to_pci_dev(dev); > > - struct pch_gpio *chip = pci_get_drvdata(pdev); > > + struct pch_gpio *chip = dev_get_drvdata(dev); > > unsigned long flags; > > > > spin_lock_irqsave(&chip->spinlock, flags); > > -- > > 2.20.1 > > > > Acked-by: Bartosz Golaszewski <bgolaszewski@baylibre.com> Pushed to my review and testing queue, thanks!
diff --git a/drivers/gpio/gpio-pch.c b/drivers/gpio/gpio-pch.c index 1d99293096f2..3f3d9a94b709 100644 --- a/drivers/gpio/gpio-pch.c +++ b/drivers/gpio/gpio-pch.c @@ -409,8 +409,7 @@ static int pch_gpio_probe(struct pci_dev *pdev, static int __maybe_unused pch_gpio_suspend(struct device *dev) { - struct pci_dev *pdev = to_pci_dev(dev); - struct pch_gpio *chip = pci_get_drvdata(pdev); + struct pch_gpio *chip = dev_get_drvdata(dev); unsigned long flags; spin_lock_irqsave(&chip->spinlock, flags); @@ -422,8 +421,7 @@ static int __maybe_unused pch_gpio_suspend(struct device *dev) static int __maybe_unused pch_gpio_resume(struct device *dev) { - struct pci_dev *pdev = to_pci_dev(dev); - struct pch_gpio *chip = pci_get_drvdata(pdev); + struct pch_gpio *chip = dev_get_drvdata(dev); unsigned long flags; spin_lock_irqsave(&chip->spinlock, flags);
Instead of using to_pci_dev + pci_get_drvdata, use dev_get_drvdata to make code simpler. Signed-off-by: Chuhong Yuan <hslester96@gmail.com> --- Changes in v2: - Change the subject line to gpio: pch: ... drivers/gpio/gpio-pch.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-)