| Message ID | 20190722192451.1947348-1-vijaykhemka@fb.com |
|---|---|
| State | Not Applicable, archived |
| Headers | show |
| Series | [1/2] ARM: dts: aspeed: tiogapass: Add VR devices | expand |
Hi Vijay, A few nitpicks. On Tue, 23 Jul 2019, at 05:10, Vijay Khemka wrote: > Addes Typo: Adds > Voltage Unnecessary capitalisation. > regulators Infineon pxe1610 devices to Facebook > tiogapass platform. > > Signed-off-by: Vijay Khemka <vijaykhemka@fb.com> > --- > .../dts/aspeed-bmc-facebook-tiogapass.dts | 36 +++++++++++++++++++ > 1 file changed, 36 insertions(+) > > diff --git a/arch/arm/boot/dts/aspeed-bmc-facebook-tiogapass.dts > b/arch/arm/boot/dts/aspeed-bmc-facebook-tiogapass.dts > index c4521eda787c..b7783833a58c 100644 > --- a/arch/arm/boot/dts/aspeed-bmc-facebook-tiogapass.dts > +++ b/arch/arm/boot/dts/aspeed-bmc-facebook-tiogapass.dts > @@ -144,6 +144,42 @@ > &i2c5 { > status = "okay"; > // CPU Voltage regulators > + vr@48 { The recommended generic name is 'regulator', so e.g. regulator@48 > + compatible = "infineon,pxe1610"; > + reg = <0x48>; > + }; > + vr@4a { > + compatible = "infineon,pxe1610"; > + reg = <0x4a>; > + }; > + vr@50 { > + compatible = "infineon,pxe1610"; > + reg = <0x50>; > + }; > + vr@52 { > + compatible = "infineon,pxe1610"; > + reg = <0x52>; > + }; > + vr@58 { > + compatible = "infineon,pxe1610"; > + reg = <0x58>; > + }; > + vr@5a { > + compatible = "infineon,pxe1610"; > + reg = <0x5a>; > + }; > + vr@68 { > + compatible = "infineon,pxe1610"; > + reg = <0x68>; > + }; > + vr@70 { > + compatible = "infineon,pxe1610"; > + reg = <0x70>; > + }; > + vr@72 { > + compatible = "infineon,pxe1610"; > + reg = <0x72>; > + }; > }; > > &i2c6 { > -- > 2.17.1 > >
On 7/22/19, 5:12 PM, "Andrew Jeffery" <andrew@aj.id.au> wrote:
Hi Vijay,
A few nitpicks.
On Tue, 23 Jul 2019, at 05:10, Vijay Khemka wrote:
> Addes
Typo: Adds
Ack
> Voltage
Unnecessary capitalisation.
Ack
> regulators Infineon pxe1610 devices to Facebook
> tiogapass platform.
>
> Signed-off-by: Vijay Khemka <vijaykhemka@fb.com>
> ---
> .../dts/aspeed-bmc-facebook-tiogapass.dts | 36 +++++++++++++++++++
> 1 file changed, 36 insertions(+)
>
> diff --git a/arch/arm/boot/dts/aspeed-bmc-facebook-tiogapass.dts
> b/arch/arm/boot/dts/aspeed-bmc-facebook-tiogapass.dts
> index c4521eda787c..b7783833a58c 100644
> --- a/arch/arm/boot/dts/aspeed-bmc-facebook-tiogapass.dts
> +++ b/arch/arm/boot/dts/aspeed-bmc-facebook-tiogapass.dts
> @@ -144,6 +144,42 @@
> &i2c5 {
> status = "okay";
> // CPU Voltage regulators
> + vr@48 {
The recommended generic name is 'regulator', so e.g. regulator@48
Ack: Submitted v2 for this patch.
> + compatible = "infineon,pxe1610";
> + reg = <0x48>;
> + };
> + vr@4a {
> + compatible = "infineon,pxe1610";
> + reg = <0x4a>;
> + };
> + vr@50 {
> + compatible = "infineon,pxe1610";
> + reg = <0x50>;
> + };
> + vr@52 {
> + compatible = "infineon,pxe1610";
> + reg = <0x52>;
> + };
> + vr@58 {
> + compatible = "infineon,pxe1610";
> + reg = <0x58>;
> + };
> + vr@5a {
> + compatible = "infineon,pxe1610";
> + reg = <0x5a>;
> + };
> + vr@68 {
> + compatible = "infineon,pxe1610";
> + reg = <0x68>;
> + };
> + vr@70 {
> + compatible = "infineon,pxe1610";
> + reg = <0x70>;
> + };
> + vr@72 {
> + compatible = "infineon,pxe1610";
> + reg = <0x72>;
> + };
> };
>
> &i2c6 {
> --
> 2.17.1
>
>
diff --git a/arch/arm/boot/dts/aspeed-bmc-facebook-tiogapass.dts b/arch/arm/boot/dts/aspeed-bmc-facebook-tiogapass.dts index c4521eda787c..b7783833a58c 100644 --- a/arch/arm/boot/dts/aspeed-bmc-facebook-tiogapass.dts +++ b/arch/arm/boot/dts/aspeed-bmc-facebook-tiogapass.dts @@ -144,6 +144,42 @@ &i2c5 { status = "okay"; // CPU Voltage regulators + vr@48 { + compatible = "infineon,pxe1610"; + reg = <0x48>; + }; + vr@4a { + compatible = "infineon,pxe1610"; + reg = <0x4a>; + }; + vr@50 { + compatible = "infineon,pxe1610"; + reg = <0x50>; + }; + vr@52 { + compatible = "infineon,pxe1610"; + reg = <0x52>; + }; + vr@58 { + compatible = "infineon,pxe1610"; + reg = <0x58>; + }; + vr@5a { + compatible = "infineon,pxe1610"; + reg = <0x5a>; + }; + vr@68 { + compatible = "infineon,pxe1610"; + reg = <0x68>; + }; + vr@70 { + compatible = "infineon,pxe1610"; + reg = <0x70>; + }; + vr@72 { + compatible = "infineon,pxe1610"; + reg = <0x72>; + }; }; &i2c6 {
Addes Voltage regulators Infineon pxe1610 devices to Facebook tiogapass platform. Signed-off-by: Vijay Khemka <vijaykhemka@fb.com> --- .../dts/aspeed-bmc-facebook-tiogapass.dts | 36 +++++++++++++++++++ 1 file changed, 36 insertions(+)