package/ncdu: bump to version 1.14
diff mbox series

Message ID 1563818223-23023-1-git-send-email-gilles.talis@gmail.com
State Accepted
Headers show
Series
  • package/ncdu: bump to version 1.14
Related show

Commit Message

Gilles Talis July 22, 2019, 5:57 p.m. UTC
Signed-off-by: Gilles Talis <gilles.talis@gmail.com>
---
 package/ncdu/ncdu.hash | 8 ++++----
 package/ncdu/ncdu.mk   | 2 +-
 2 files changed, 5 insertions(+), 5 deletions(-)

Comments

Baruch Siach July 23, 2019, 4:17 a.m. UTC | #1
Hi Gilles,

On Mon, Jul 22, 2019 at 07:57:02PM +0200, Gilles Talis wrote:
> Signed-off-by: Gilles Talis <gilles.talis@gmail.com>
> ---
>  package/ncdu/ncdu.hash | 8 ++++----
>  package/ncdu/ncdu.mk   | 2 +-
>  2 files changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/package/ncdu/ncdu.hash b/package/ncdu/ncdu.hash
> index 7326a15..97ac287 100644
> --- a/package/ncdu/ncdu.hash
> +++ b/package/ncdu/ncdu.hash
> @@ -1,6 +1,6 @@
> -# From http://dev.yorhel.nl/download/ncdu-1.13.tar.gz.{md5,sha1}
> -md5 67239592ac41f42290f52ab89ff198be  ncdu-1.13.tar.gz
> -sha1 3233c4185208d9989ac528a94817ed92dd59c773  ncdu-1.13.tar.gz
> +# From http://dev.yorhel.nl/download/ncdu-1.14.tar.gz.{md5,sha1}
> +md5 d26c0aa57728c19969c3c5036fa272a0  ncdu-1.14.tar.gz
> +sha1 28c7003ad23d2e3a2d22d2c349bb0c7170752396  ncdu-1.14.tar.gz
>  
>  # computed locally
> -sha256 0ee47c3742a867ace26eb429cce593b54ab4ccb4c4a97d62e41363cbf80c8a24 COPYING
> +sha256 a05f1fd38432052dc8588da66b8bf3e9e103e29a82c0b5d72c65d4d9fc830f2e COPYING

What has changed in the license file? Please explain in the commit log.

baruch

> diff --git a/package/ncdu/ncdu.mk b/package/ncdu/ncdu.mk
> index 9a7170d..87508f5 100644
> --- a/package/ncdu/ncdu.mk
> +++ b/package/ncdu/ncdu.mk
> @@ -4,7 +4,7 @@
>  #
>  ################################################################################
>  
> -NCDU_VERSION = 1.13
> +NCDU_VERSION = 1.14
>  NCDU_SITE = http://dev.yorhel.nl/download
>  
>  NCDU_DEPENDENCIES = ncurses
Gilles Talis July 23, 2019, 5:30 a.m. UTC | #2
Hello Baruch, all,

Thanks for your review.

Le mar. 23 juil. 2019 à 06:17, Baruch Siach <baruch@tkos.co.il> a écrit :
>
> Hi Gilles,
>
> On Mon, Jul 22, 2019 at 07:57:02PM +0200, Gilles Talis wrote:
> > Signed-off-by: Gilles Talis <gilles.talis@gmail.com>
> > ---
> >  package/ncdu/ncdu.hash | 8 ++++----
> >  package/ncdu/ncdu.mk   | 2 +-
> >  2 files changed, 5 insertions(+), 5 deletions(-)
> >
> > diff --git a/package/ncdu/ncdu.hash b/package/ncdu/ncdu.hash
> > index 7326a15..97ac287 100644
> > --- a/package/ncdu/ncdu.hash
> > +++ b/package/ncdu/ncdu.hash
> > @@ -1,6 +1,6 @@
> > -# From http://dev.yorhel.nl/download/ncdu-1.13.tar.gz.{md5,sha1}
> > -md5 67239592ac41f42290f52ab89ff198be  ncdu-1.13.tar.gz
> > -sha1 3233c4185208d9989ac528a94817ed92dd59c773  ncdu-1.13.tar.gz
> > +# From http://dev.yorhel.nl/download/ncdu-1.14.tar.gz.{md5,sha1}
> > +md5 d26c0aa57728c19969c3c5036fa272a0  ncdu-1.14.tar.gz
> > +sha1 28c7003ad23d2e3a2d22d2c349bb0c7170752396  ncdu-1.14.tar.gz
> >
> >  # computed locally
> > -sha256 0ee47c3742a867ace26eb429cce593b54ab4ccb4c4a97d62e41363cbf80c8a24 COPYING
> > +sha256 a05f1fd38432052dc8588da66b8bf3e9e103e29a82c0b5d72c65d4d9fc830f2e COPYING
>
> What has changed in the license file? Please explain in the commit log.
this is a year bump (2018 -> 2019) in the copyright statement. Do you
think it is worth mentioning in the commit log? If you feel it is,
I'll send a v2.

thanks
Gilles.
Baruch Siach July 23, 2019, 5:44 a.m. UTC | #3
Hi Gilles,

On Tue, Jul 23, 2019 at 07:30:46AM +0200, Gilles Talis wrote:
> Le mar. 23 juil. 2019 à 06:17, Baruch Siach <baruch@tkos.co.il> a écrit :
> > On Mon, Jul 22, 2019 at 07:57:02PM +0200, Gilles Talis wrote:
> > > Signed-off-by: Gilles Talis <gilles.talis@gmail.com>
> > > ---
> > >  package/ncdu/ncdu.hash | 8 ++++----
> > >  package/ncdu/ncdu.mk   | 2 +-
> > >  2 files changed, 5 insertions(+), 5 deletions(-)
> > >
> > > diff --git a/package/ncdu/ncdu.hash b/package/ncdu/ncdu.hash
> > > index 7326a15..97ac287 100644
> > > --- a/package/ncdu/ncdu.hash
> > > +++ b/package/ncdu/ncdu.hash
> > > @@ -1,6 +1,6 @@
> > > -# From http://dev.yorhel.nl/download/ncdu-1.13.tar.gz.{md5,sha1}
> > > -md5 67239592ac41f42290f52ab89ff198be  ncdu-1.13.tar.gz
> > > -sha1 3233c4185208d9989ac528a94817ed92dd59c773  ncdu-1.13.tar.gz
> > > +# From http://dev.yorhel.nl/download/ncdu-1.14.tar.gz.{md5,sha1}
> > > +md5 d26c0aa57728c19969c3c5036fa272a0  ncdu-1.14.tar.gz
> > > +sha1 28c7003ad23d2e3a2d22d2c349bb0c7170752396  ncdu-1.14.tar.gz
> > >
> > >  # computed locally
> > > -sha256 0ee47c3742a867ace26eb429cce593b54ab4ccb4c4a97d62e41363cbf80c8a24 COPYING
> > > +sha256 a05f1fd38432052dc8588da66b8bf3e9e103e29a82c0b5d72c65d4d9fc830f2e COPYING
> >
> > What has changed in the license file? Please explain in the commit log.
> this is a year bump (2018 -> 2019) in the copyright statement. Do you
> think it is worth mentioning in the commit log? If you feel it is,
> I'll send a v2.

It is worth mentioning in the commit log. The whole point of license file 
hashes is to detect license changes. Blind license hash updates defeat that 
purpose.

Not sure it's worth v2 though. The maintainers can add the copyright year 
update comment in the log when applying.

baruch
Gilles Talis July 23, 2019, 2:33 p.m. UTC | #4
Hello Baruch,

Le mar. 23 juil. 2019 à 07:44, Baruch Siach <baruch@tkos.co.il> a écrit :

> It is worth mentioning in the commit log. The whole point of license file
> hashes is to detect license changes. Blind license hash updates defeat that
> purpose.
Understood. Thanks for the clarification.

>
> Not sure it's worth v2 though. The maintainers can add the copyright year
> update comment in the log when applying.
OK. Let's see what maintainers do on this one. I'll send a v2 if necessary.

Gilles.
Thomas Petazzoni July 26, 2019, 8:58 p.m. UTC | #5
Hello,

On Mon, 22 Jul 2019 19:57:02 +0200
Gilles Talis <gilles.talis@gmail.com> wrote:

> Signed-off-by: Gilles Talis <gilles.talis@gmail.com>
> ---
>  package/ncdu/ncdu.hash | 8 ++++----
>  package/ncdu/ncdu.mk   | 2 +-
>  2 files changed, 5 insertions(+), 5 deletions(-)

Applied to master after updating the commit log to explain why the hash
of the license file has changed (thanks Baruch for noticing).

Thanks,

Thomas

Patch
diff mbox series

diff --git a/package/ncdu/ncdu.hash b/package/ncdu/ncdu.hash
index 7326a15..97ac287 100644
--- a/package/ncdu/ncdu.hash
+++ b/package/ncdu/ncdu.hash
@@ -1,6 +1,6 @@ 
-# From http://dev.yorhel.nl/download/ncdu-1.13.tar.gz.{md5,sha1}
-md5 67239592ac41f42290f52ab89ff198be  ncdu-1.13.tar.gz
-sha1 3233c4185208d9989ac528a94817ed92dd59c773  ncdu-1.13.tar.gz
+# From http://dev.yorhel.nl/download/ncdu-1.14.tar.gz.{md5,sha1}
+md5 d26c0aa57728c19969c3c5036fa272a0  ncdu-1.14.tar.gz
+sha1 28c7003ad23d2e3a2d22d2c349bb0c7170752396  ncdu-1.14.tar.gz
 
 # computed locally
-sha256 0ee47c3742a867ace26eb429cce593b54ab4ccb4c4a97d62e41363cbf80c8a24 COPYING
+sha256 a05f1fd38432052dc8588da66b8bf3e9e103e29a82c0b5d72c65d4d9fc830f2e COPYING
diff --git a/package/ncdu/ncdu.mk b/package/ncdu/ncdu.mk
index 9a7170d..87508f5 100644
--- a/package/ncdu/ncdu.mk
+++ b/package/ncdu/ncdu.mk
@@ -4,7 +4,7 @@ 
 #
 ################################################################################
 
-NCDU_VERSION = 1.13
+NCDU_VERSION = 1.14
 NCDU_SITE = http://dev.yorhel.nl/download
 
 NCDU_DEPENDENCIES = ncurses