| Message ID | 20190722150241.345609-2-tmaimon77@gmail.com |
|---|---|
| State | Changes Requested, archived |
| Headers | show |
| Series | hwrng: npcm: add NPCM RNG driver support | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success |
On Mon, Jul 22, 2019 at 06:02:40PM +0300, Tomer Maimon wrote: > Added device tree binding documentation for Nuvoton BMC > NPCM Random Number Generator (RNG). > > Signed-off-by: Tomer Maimon <tmaimon77@gmail.com> > --- > .../bindings/rng/nuvoton,npcm-rng.txt | 17 +++++++++++++++++ > 1 file changed, 17 insertions(+) > create mode 100644 Documentation/devicetree/bindings/rng/nuvoton,npcm-rng.txt > > diff --git a/Documentation/devicetree/bindings/rng/nuvoton,npcm-rng.txt b/Documentation/devicetree/bindings/rng/nuvoton,npcm-rng.txt > new file mode 100644 > index 000000000000..a697b4425fb3 > --- /dev/null > +++ b/Documentation/devicetree/bindings/rng/nuvoton,npcm-rng.txt > @@ -0,0 +1,17 @@ > +NPCM SoC Random Number Generator > + > +Required properties: > +- compatible : "nuvoton,npcm750-rng" for the NPCM7XX BMC. > +- reg : Specifies physical base address and size of the registers. > + > +Optional property: > +- quality : estimated number of bits of true entropy per 1024 bits > + read from the rng. > + If this property is not defined, it defaults to 1000. This would need a vendor prefix, however, I think it should be implied by the compatible string. It is fixed per SoC, right?
On Tue, Aug 13, 2019 at 2:36 AM Rob Herring <robh@kernel.org> wrote: > > On Mon, Jul 22, 2019 at 06:02:40PM +0300, Tomer Maimon wrote: > > Added device tree binding documentation for Nuvoton BMC > > NPCM Random Number Generator (RNG). > > > > Signed-off-by: Tomer Maimon <tmaimon77@gmail.com> > > --- > > .../bindings/rng/nuvoton,npcm-rng.txt | 17 +++++++++++++++++ > > 1 file changed, 17 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/rng/nuvoton,npcm-rng.txt > > > > diff --git a/Documentation/devicetree/bindings/rng/nuvoton,npcm-rng.txt b/Documentation/devicetree/bindings/rng/nuvoton,npcm-rng.txt > > new file mode 100644 > > index 000000000000..a697b4425fb3 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/rng/nuvoton,npcm-rng.txt > > @@ -0,0 +1,17 @@ > > +NPCM SoC Random Number Generator > > + > > +Required properties: > > +- compatible : "nuvoton,npcm750-rng" for the NPCM7XX BMC. > > +- reg : Specifies physical base address and size of the registers. > > + > > +Optional property: > > +- quality : estimated number of bits of true entropy per 1024 bits > > + read from the rng. > > + If this property is not defined, it defaults to 1000. > > This would need a vendor prefix, however, I think it should be implied > by the compatible string. It is fixed per SoC, right? Tomer is on vacation, so I answer instead: This value is the same for all our SoC flavor that contains this RNG HW.
diff --git a/Documentation/devicetree/bindings/rng/nuvoton,npcm-rng.txt b/Documentation/devicetree/bindings/rng/nuvoton,npcm-rng.txt new file mode 100644 index 000000000000..a697b4425fb3 --- /dev/null +++ b/Documentation/devicetree/bindings/rng/nuvoton,npcm-rng.txt @@ -0,0 +1,17 @@ +NPCM SoC Random Number Generator + +Required properties: +- compatible : "nuvoton,npcm750-rng" for the NPCM7XX BMC. +- reg : Specifies physical base address and size of the registers. + +Optional property: +- quality : estimated number of bits of true entropy per 1024 bits + read from the rng. + If this property is not defined, it defaults to 1000. + +Example: + +rng: rng@f000b000 { + compatible = "nuvoton,npcm750-rng"; + reg = <0xf000b000 0x8>; +};
Added device tree binding documentation for Nuvoton BMC NPCM Random Number Generator (RNG). Signed-off-by: Tomer Maimon <tmaimon77@gmail.com> --- .../bindings/rng/nuvoton,npcm-rng.txt | 17 +++++++++++++++++ 1 file changed, 17 insertions(+) create mode 100644 Documentation/devicetree/bindings/rng/nuvoton,npcm-rng.txt