| Message ID | 20190722101628.21195-2-phil@nwl.cc |
|---|---|
| State | Accepted |
| Delegated to: | Pablo Neira |
| Headers | show |
| Series | Larger xtables-save review | expand |
diff --git a/iptables/xtables-eb.c b/iptables/xtables-eb.c index 171f41b0f616e..b8d89ad974a42 100644 --- a/iptables/xtables-eb.c +++ b/iptables/xtables-eb.c @@ -1180,7 +1180,7 @@ print_zero: if (ebt_command_default(&cs)) xtables_error(PARAMETER_PROBLEM, "Unknown argument: '%s'", - argv[optind - 1]); + argv[optind]); if (command != 'A' && command != 'I' && command != 'D' && command != 'C')
With empty ruleset, ebtables-nft would report the wrong argv: | % sudo ./install/sbin/ebtables-nft -vnL | ebtables v1.8.3 (nf_tables): Unknown argument: './install/sbin/ebtables-nft' | Try `ebtables -h' or 'ebtables --help' for more information. After a (successful) call to 'ebtables-nft -L', this would even segfault: | % sudo ./install/sbin/ebtables-nft -vnL | zsh: segmentation fault sudo ./install/sbin/ebtables-nft -vnL Fixes: acde6be32036f ("ebtables-translate: Fix segfault while parsing extension options") Signed-off-by: Phil Sutter <phil@nwl.cc> --- iptables/xtables-eb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)