| Message ID | 20190721113105.19301-1-jeremy@azazel.net |
|---|---|
| State | Accepted |
| Delegated to: | David Miller |
| Headers | show |
| Series | [net] kbuild: add net/netfilter/nf_tables_offload.h to header-test blacklist. | expand |
On Sun, Jul 21, 2019 at 12:31:05PM +0100, Jeremy Sowden wrote: > net/netfilter/nf_tables_offload.h includes net/netfilter/nf_tables.h > which is itself on the blacklist. > > Reported-by: Jakub Kicinski <jakub.kicinski@netronome.com> > Signed-off-by: Jeremy Sowden <jeremy@azazel.net> Acked-by: Pablo Neira Ayuso <pablo@netfilter.org> Thanks, I think it would be good later on to review all of the netfilter headers and make them compile via this new CONFIG_HEADER_TEST Kconfig knob.
From: Jeremy Sowden <jeremy@azazel.net> Date: Sun, 21 Jul 2019 12:31:05 +0100 > net/netfilter/nf_tables_offload.h includes net/netfilter/nf_tables.h > which is itself on the blacklist. > > Reported-by: Jakub Kicinski <jakub.kicinski@netronome.com> > Signed-off-by: Jeremy Sowden <jeremy@azazel.net> Applied.
On 2019-07-21, at 20:26:08 +0200, Pablo Neira Ayuso wrote: > On Sun, Jul 21, 2019 at 12:31:05PM +0100, Jeremy Sowden wrote: > > net/netfilter/nf_tables_offload.h includes net/netfilter/nf_tables.h > > which is itself on the blacklist. > > > > Reported-by: Jakub Kicinski <jakub.kicinski@netronome.com> > > Signed-off-by: Jeremy Sowden <jeremy@azazel.net> > > Acked-by: Pablo Neira Ayuso <pablo@netfilter.org> > > Thanks, I think it would be good later on to review all of the > netfilter headers and make them compile via this new > CONFIG_HEADER_TEST Kconfig knob. Definitely. The problem in this instance is that linux/netfilter.h wraps some struct definitions and inline functions in "#ifdef CONFIG_NETFILTER" / "#endif", but some of these are required by code defined in other header-files that are not so wrapped, so when CONFIG_NETFILTER is not defined, compilation of those header-files fails. I only took a cursory glance over the week-end and stopped once I found the blacklist. I'll take a more thorough look when I have some time, hopefully later this week. J.
diff --git a/include/Kbuild b/include/Kbuild index 7e9f1acb9dd5..8de846a83d8f 100644 --- a/include/Kbuild +++ b/include/Kbuild @@ -909,6 +909,7 @@ header-test- += net/netfilter/nf_tables.h header-test- += net/netfilter/nf_tables_core.h header-test- += net/netfilter/nf_tables_ipv4.h header-test- += net/netfilter/nf_tables_ipv6.h +header-test- += net/netfilter/nf_tables_offload.h header-test- += net/netfilter/nft_fib.h header-test- += net/netfilter/nft_meta.h header-test- += net/netfilter/nft_reject.h
net/netfilter/nf_tables_offload.h includes net/netfilter/nf_tables.h which is itself on the blacklist. Reported-by: Jakub Kicinski <jakub.kicinski@netronome.com> Signed-off-by: Jeremy Sowden <jeremy@azazel.net> --- include/Kbuild | 1 + 1 file changed, 1 insertion(+)