From patchwork Fri Jul 19 22:11:20 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: DJ Delorie X-Patchwork-Id: 1134319 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=sourceware.org (client-ip=209.132.180.131; helo=sourceware.org; envelope-from=libc-alpha-return-103832-incoming=patchwork.ozlabs.org@sourceware.org; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; secure) header.d=sourceware.org header.i=@sourceware.org header.b="e4BOK4Bj"; dkim-atps=neutral Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 45r4wL0w6Kz9s8m for ; Sat, 20 Jul 2019 08:11:29 +1000 (AEST) DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:date:message-id:from:to:subject; q=dns; s= default; b=jiytTqhVuW+c9ClMEq4TDYwppQ5po5oDAMMTOuiu2D8+QL35T+IET EtutWUCRPmKhjQxCBgqp/Cf06Xec4FLZJhcGTeU8CkgoXFOdFSrm2jQflzF1X7zU TDPFNNtj57szezfk1MQhgaONKzS7VYl9hR0NfKWwlgqH8lXhk6mWDs= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:date:message-id:from:to:subject; s=default; bh=KZgAuiTbjZ6yNBlg1x0vUD3UkxA=; b=e4BOK4BjBTf0pfpri8Hl/FWqaGb8 zqoTDh/4aXjT/pVrPIvVRAo+ampUbl9+FhwJPDoGjl+GqFrvI2FSDH28rWO72oQF gItF+JTo02O2Wc8KdtPty0Pc9XvIsoZBYwuYcMSu1NjxBUvfAqhjS9s8BaQjGg2N De04ClKQHLhQdt8= Received: (qmail 50815 invoked by alias); 19 Jul 2019 22:11:24 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Delivered-To: mailing list libc-alpha@sourceware.org Received: (qmail 50807 invoked by uid 89); 19 Jul 2019 22:11:24 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-17.4 required=5.0 tests=AWL, BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, SPF_HELO_PASS autolearn=ham version=3.3.1 spammy= X-HELO: mx1.redhat.com Date: Fri, 19 Jul 2019 18:11:20 -0400 Message-Id: From: DJ Delorie To: libc-alpha@sourceware.org Subject: "make check" times While digging for some low-hanging fruit in "make" times, I did this: That one instance of "head" is called over 6000 times per "make check", and as it's the only non-builtin in that script, it adds about 11 seconds of overhead compared to just reading that one line with builtins. My question here is: how much of a time savings is worth the complexity of said savings? diff --git a/scripts/merge-test-results.sh b/scripts/merge-test-results.sh index 919bbae253..7088ef6996 100755 --- a/scripts/merge-test-results.sh +++ b/scripts/merge-test-results.sh @@ -35,7 +35,11 @@ case $type in subdir=${subdir:+$subdir/} for t in "$@"; do if [ -s "$objpfx$t.test-result" ]; then - head -n1 "$objpfx$t.test-result" + #head -n1 "$objpfx$t.test-result" + exec 6<"$objpfx$t.test-result" + read line <&6 + echo $line + exec 6<&- else echo "UNRESOLVED: $subdir$t" fi