From patchwork Fri Jul 19 21:26:12 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Eugeniu Rosca X-Patchwork-Id: 1134306 X-Patchwork-Delegate: trini@ti.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=lists.denx.de (client-ip=81.169.180.215; helo=lists.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="Z+eT1toP"; dkim-atps=neutral Received: from lists.denx.de (dione.denx.de [81.169.180.215]) by ozlabs.org (Postfix) with ESMTP id 45r3zx1gSKz9s4Y for ; Sat, 20 Jul 2019 07:29:33 +1000 (AEST) Received: by lists.denx.de (Postfix, from userid 105) id E5E0BC21DB5; Fri, 19 Jul 2019 21:28:43 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=FREEMAIL_FROM, T_DKIM_INVALID autolearn=unavailable autolearn_force=no version=3.4.0 Received: from lists.denx.de (localhost [IPv6:::1]) by lists.denx.de (Postfix) with ESMTP id 53D51C21DED; Fri, 19 Jul 2019 21:28:23 +0000 (UTC) Received: by lists.denx.de (Postfix, from userid 105) id 5FADAC21E0B; Fri, 19 Jul 2019 21:28:07 +0000 (UTC) Received: from mail-wr1-f65.google.com (mail-wr1-f65.google.com [209.85.221.65]) by lists.denx.de (Postfix) with ESMTPS id 9A8CEC21DF9 for ; Fri, 19 Jul 2019 21:28:05 +0000 (UTC) Received: by mail-wr1-f65.google.com with SMTP id f9so33484928wre.12 for ; Fri, 19 Jul 2019 14:28:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=8Oz/IfSBHjDBhcawTVYNDbK9mrou166VMvyIOoRYOV4=; b=Z+eT1toPOvp/WSScY5BfaNxfpxguPs3zwGd4ZVfazYWG7/Ssa7iioq3BaGCQIa0sCw 3wOMGBoltPAuzOxu4y/ETBlZQV2MlEw8ZODIcF+pGq3ZfztzJE0JNLCTDR2vrrhUIICq d1W6rsYr+qGnTywpgbOpxM7hPe1MR7j3k1ATTkdj5qdj4aab7NbyXC/jFRn0DR9Gjh+d flAtru3J8mYlHS2fW/ggEfixAhwKSWlJGoFmfUhRJG3+CZ5He6Xlz4zviNeHooHJ6Uib rdV0ew7BuO4mjLYy0/eh0F5qxJ1+MV10ATGszBSrhRHAydp/j0jQHvGPi5YOBQTAk48g cdfA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=8Oz/IfSBHjDBhcawTVYNDbK9mrou166VMvyIOoRYOV4=; b=ovmj8dEoISik2BnSvk4AVOB4TtvFd45+AxusTuoMKWBS+b4Bdo6ph3ENT9Fr73URH7 HNOiWyz7E+vy8/TvVRplhbf7egMOmTikMAzYhGv2G2A7Yu3TrC9ygZLIY1Ra+uGlQUH9 /4o8EMjOMD8XrZMevXg92R+nfPAbzeKenUmf6o3hbRP8ZjA6WThASTJ2Ysn3c9AmmdJm 55mFGIW70eU/TRTd8da3fF5ELx2GMwDc/20z3H1zDBAUg6EfbzfuMmyg5PhtfzFsT7aV z28+PLRfCguCeicZh094yFTylOioHByQU1yUJ24GfdIfeNG9aUHBrRHUsGAFRPINFORT 6UzA== X-Gm-Message-State: APjAAAWFo1C/kzpjs9NobDdtPl+UCB9w8mNc+7HeYcobE8O9zkbmPRut emz4v9JKyXqOhDbHlPkBrgKMJe38FmFgnw== X-Google-Smtp-Source: APXvYqz9GMJFiXhVnF0Rr8cW1pqS+SX+r3HtAzEmOhlOuTIxhTjLqopK2v6izje8Jtf/qbih9AycGg== X-Received: by 2002:adf:80e6:: with SMTP id 93mr20716655wrl.298.1563571685088; Fri, 19 Jul 2019 14:28:05 -0700 (PDT) Received: from erosca.t-mobile.de ([84.117.13.234]) by smtp.gmail.com with ESMTPSA id 32sm26309800wrh.76.2019.07.19.14.28.04 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Fri, 19 Jul 2019 14:28:04 -0700 (PDT) From: Eugeniu Rosca X-Google-Original-From: Eugeniu Rosca To: u-boot@lists.denx.de, Simon Glass , Sam Protsenko , Igor Opaniuk , Tom Rini Date: Fri, 19 Jul 2019 23:26:12 +0200 Message-Id: <20190719212614.25527-3-erosca@de.adit-jv.com> X-Mailer: git-send-email 2.22.0 In-Reply-To: <20190719212614.25527-1-erosca@de.adit-jv.com> References: <20190719212614.25527-1-erosca@de.adit-jv.com> MIME-Version: 1.0 Cc: Eugeniu Rosca , Eugeniu Rosca Subject: [U-Boot] [PATCH v3 2/4] cmd: bcb: Fix duplicated handling in two case-branches X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.18 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" Fix warning V1037 reported by PVS-Studio Static Analyzer: Two or more case-branches perform the same actions. Check lines: 49, 53 Fixes: db7b7a05b267 ("cmd: Add 'bcb' command to read/modify/write BCB fields") Signed-off-by: Eugeniu Rosca Reviewed-by: Igor Opaniuk Reviewed-by: Sam Protsenko --- v3: - No changes - Added 'Reviewed-by: Sam Protsenko' from v2 v2: - Added 'Reviewed-by: Igor Opaniuk' from v1 - https://patchwork.ozlabs.org/patch/1131357/ v1: - https://patchwork.ozlabs.org/patch/1131301/ --- cmd/bcb.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/cmd/bcb.c b/cmd/bcb.c index 2bd5a744deb5..3b1c7434e287 100644 --- a/cmd/bcb.c +++ b/cmd/bcb.c @@ -46,9 +46,6 @@ static int bcb_is_misused(int argc, char *const argv[]) switch (cmd) { case BCB_CMD_LOAD: - if (argc != 3) - goto err; - break; case BCB_CMD_FIELD_SET: if (argc != 3) goto err;