[1/1] package/iputils: fix build without NLS
diff mbox series

Message ID 20190719211152.3812-1-fontaine.fabrice@gmail.com
State Accepted
Headers show
Series
  • [1/1] package/iputils: fix build without NLS
Related show

Commit Message

Fabrice Fontaine July 19, 2019, 9:11 p.m. UTC
Set USE_GETTEXT depending on BR2_SYSTEM_ENABLE_NLS as otherwise build
will fail if gettext is not installed on host because USE_GETTEXT is
enabled by default since version 20190324 and
https://github.com/iputils/iputils/commit/2615a527209bb408b54028ef6405075cadd4541b

Fixes:
 - http://autobuild.buildroot.org/results/127823ddbd75336abc0fe0e9bd11e4f5249df87c

Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
---
 package/iputils/iputils.mk | 6 ++++++
 1 file changed, 6 insertions(+)

Comments

Petr Vorel July 22, 2019, 6:29 a.m. UTC | #1
Hi Fabrice,

> Set USE_GETTEXT depending on BR2_SYSTEM_ENABLE_NLS as otherwise build
> will fail if gettext is not installed on host because USE_GETTEXT is
> enabled by default since version 20190324 and
> https://github.com/iputils/iputils/commit/2615a527209bb408b54028ef6405075cadd4541b

> Fixes:
>  - http://autobuild.buildroot.org/results/127823ddbd75336abc0fe0e9bd11e4f5249df87c

> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
Acked-by: Petr Vorel <petr.vorel@gmail.com>

Thanks for fixing it!
Hope that's the last one needed due changing build system to meson :).

Kind regards,
Petr
Thomas Petazzoni Aug. 1, 2019, 1:48 p.m. UTC | #2
On Fri, 19 Jul 2019 23:11:52 +0200
Fabrice Fontaine <fontaine.fabrice@gmail.com> wrote:

> Set USE_GETTEXT depending on BR2_SYSTEM_ENABLE_NLS as otherwise build
> will fail if gettext is not installed on host because USE_GETTEXT is
> enabled by default since version 20190324 and
> https://github.com/iputils/iputils/commit/2615a527209bb408b54028ef6405075cadd4541b
> 
> Fixes:
>  - http://autobuild.buildroot.org/results/127823ddbd75336abc0fe0e9bd11e4f5249df87c
> 
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> ---
>  package/iputils/iputils.mk | 6 ++++++
>  1 file changed, 6 insertions(+)

Applied to master, thanks.

Thomas

Patch
diff mbox series

diff --git a/package/iputils/iputils.mk b/package/iputils/iputils.mk
index 8e6a3e2fc5..b28222138f 100644
--- a/package/iputils/iputils.mk
+++ b/package/iputils/iputils.mk
@@ -49,6 +49,12 @@  IPUTILS_CONF_OPTS += -DUSE_CRYPTO=none
 IPUTILS_CONF_OPTS += -DBUILD_NINFOD=false
 endif
 
+ifeq ($(BR2_SYSTEM_ENABLE_NLS),y)
+IPUTILS_CONF_OPTS += -DUSE_GETTEXT=true
+else
+IPUTILS_CONF_OPTS += -DUSE_GETTEXT=false
+endif
+
 IPUTILS_CONF_OPTS += -DBUILD_TRACEROUTE6=true
 
 # XSL Stylesheets for DocBook 5 not packaged for buildroot