Patchwork [U-Boot] MX31: mx31pdk: Remove nand_spl config.mk file

login
register
mail settings
Submitter Fabio Estevam
Date Sept. 5, 2011, 6:55 p.m.
Message ID <1315248912-1099-1-git-send-email-fabio.estevam@freescale.com>
Download mbox | patch
Permalink /patch/113430/
State Accepted
Commit 29b62c012db61657a1bd6105e14d60c7e54b0539
Delegated to: Stefano Babic
Headers show

Comments

Fabio Estevam - Sept. 5, 2011, 6:55 p.m.
No need to have a config.mk to only store a single line.

Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
---
 nand_spl/board/freescale/mx31pdk/Makefile  |    2 +-
 nand_spl/board/freescale/mx31pdk/config.mk |    1 -
 2 files changed, 1 insertions(+), 2 deletions(-)
 delete mode 100644 nand_spl/board/freescale/mx31pdk/config.mk
Fabio Estevam - Sept. 12, 2011, 5:13 p.m.
Hi Stefano,

On Mon, Sep 5, 2011 at 3:55 PM, Fabio Estevam
<fabio.estevam@freescale.com> wrote:
> No need to have a config.mk to only store a single line.
>
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
> ---
>  nand_spl/board/freescale/mx31pdk/Makefile  |    2 +-
>  nand_spl/board/freescale/mx31pdk/config.mk |    1 -
>  2 files changed, 1 insertions(+), 2 deletions(-)
>  delete mode 100644 nand_spl/board/freescale/mx31pdk/config.mk

Any comments on this one?

Thanks,

Fabio Estevam
Stefano Babic - Sept. 13, 2011, 11:13 a.m.
On 09/12/2011 07:13 PM, Fabio Estevam wrote:
> Hi Stefano,
> 
> On Mon, Sep 5, 2011 at 3:55 PM, Fabio Estevam
> <fabio.estevam@freescale.com> wrote:
>> No need to have a config.mk to only store a single line.
>>
>> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
>> ---
>>  nand_spl/board/freescale/mx31pdk/Makefile  |    2 +-
>>  nand_spl/board/freescale/mx31pdk/config.mk |    1 -
>>  2 files changed, 1 insertions(+), 2 deletions(-)
>>  delete mode 100644 nand_spl/board/freescale/mx31pdk/config.mk
> 
> Any comments on this one?

No, it looks ok for me - it is on my todo list (next branch).

Acked-by: Stefano Babic <sbabic@denx.de>

Best regards,
Stefano Babic

Patch

diff --git a/nand_spl/board/freescale/mx31pdk/Makefile b/nand_spl/board/freescale/mx31pdk/Makefile
index e6ec10a..87784d2 100644
--- a/nand_spl/board/freescale/mx31pdk/Makefile
+++ b/nand_spl/board/freescale/mx31pdk/Makefile
@@ -1,7 +1,7 @@ 
 CONFIG_NAND_SPL	= y
+PAD_TO	:= 2048
 
 include $(TOPDIR)/config.mk
-include $(TOPDIR)/nand_spl/board/$(BOARDDIR)/config.mk
 
 nandobj	:= $(OBJTREE)/nand_spl/
 
diff --git a/nand_spl/board/freescale/mx31pdk/config.mk b/nand_spl/board/freescale/mx31pdk/config.mk
deleted file mode 100644
index 68afbf1..0000000
--- a/nand_spl/board/freescale/mx31pdk/config.mk
+++ /dev/null
@@ -1 +0,0 @@ 
-PAD_TO	:= 2048