From patchwork Mon Sep 5 18:02:42 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Fabio Estevam X-Patchwork-Id: 113420 X-Patchwork-Delegate: sbabic@denx.de Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from theia.denx.de (theia.denx.de [85.214.87.163]) by ozlabs.org (Postfix) with ESMTP id 4A0FCB6F7D for ; Tue, 6 Sep 2011 04:02:28 +1000 (EST) Received: from localhost (localhost [127.0.0.1]) by theia.denx.de (Postfix) with ESMTP id 0E4B0280AC; Mon, 5 Sep 2011 20:02:25 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at theia.denx.de Received: from theia.denx.de ([127.0.0.1]) by localhost (theia.denx.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id TeEkSopSDsk7; Mon, 5 Sep 2011 20:02:24 +0200 (CEST) Received: from theia.denx.de (localhost [127.0.0.1]) by theia.denx.de (Postfix) with ESMTP id 9F549280A4; Mon, 5 Sep 2011 20:02:22 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by theia.denx.de (Postfix) with ESMTP id DE3B628095 for ; Mon, 5 Sep 2011 20:02:19 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at theia.denx.de Received: from theia.denx.de ([127.0.0.1]) by localhost (theia.denx.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id j2-9r6zdBV5d for ; Mon, 5 Sep 2011 20:02:18 +0200 (CEST) X-policyd-weight: NOT_IN_SBL_XBL_SPAMHAUS=-1.5 NOT_IN_SPAMCOP=-1.5 NOT_IN_BL_NJABL=-1.5 (only DNSBL check requested) Received: from DB3EHSOBE006.bigfish.com (db3ehsobe006.messaging.microsoft.com [213.199.154.144]) by theia.denx.de (Postfix) with ESMTPS id 99F4A28094 for ; Mon, 5 Sep 2011 20:02:16 +0200 (CEST) Received: from mail111-db3-R.bigfish.com (10.3.81.247) by DB3EHSOBE006.bigfish.com (10.3.84.26) with Microsoft SMTP Server id 14.1.225.22; Mon, 5 Sep 2011 18:02:16 +0000 Received: from mail111-db3 (localhost.localdomain [127.0.0.1]) by mail111-db3-R.bigfish.com (Postfix) with ESMTP id 3FB5AD200F4; Mon, 5 Sep 2011 18:02:16 +0000 (UTC) X-SpamScore: 0 X-BigFish: VS0(zzzz1202hzz8275bhz2dh2a8h668h839h61h) X-Spam-TCS-SCL: 0:0 X-Forefront-Antispam-Report: CIP:70.37.183.190; KIP:(null); UIP:(null); IPVD:NLI; H:mail.freescale.net; RD:none; EFVD:NLI Received: from mail111-db3 (localhost.localdomain [127.0.0.1]) by mail111-db3 (MessageSwitch) id 1315245735929369_14503; Mon, 5 Sep 2011 18:02:15 +0000 (UTC) Received: from DB3EHSMHS015.bigfish.com (unknown [10.3.81.251]) by mail111-db3.bigfish.com (Postfix) with ESMTP id DC31BAC004C; Mon, 5 Sep 2011 18:02:15 +0000 (UTC) Received: from mail.freescale.net (70.37.183.190) by DB3EHSMHS015.bigfish.com (10.3.87.115) with Microsoft SMTP Server (TLS) id 14.1.225.22; Mon, 5 Sep 2011 18:02:15 +0000 Received: from az33smr02.freescale.net (10.64.34.200) by 039-SN1MMR1-002.039d.mgd.msft.net (10.84.1.15) with Microsoft SMTP Server id 14.1.323.7; Mon, 5 Sep 2011 13:02:14 -0500 Received: from fabio-Latitude-E6410.am.freescale.net ([10.29.240.184]) by az33smr02.freescale.net (8.13.1/8.13.0) with ESMTP id p85I2AwO017959; Mon, 5 Sep 2011 13:02:12 -0500 (CDT) From: Fabio Estevam To: Date: Mon, 5 Sep 2011 15:02:42 -0300 Message-ID: <1315245763-13217-2-git-send-email-fabio.estevam@freescale.com> X-Mailer: git-send-email 1.7.1 In-Reply-To: <1315245763-13217-1-git-send-email-fabio.estevam@freescale.com> References: <1315245763-13217-1-git-send-email-fabio.estevam@freescale.com> MIME-Version: 1.0 X-OriginatorOrg: freescale.com Cc: Fabio Estevam Subject: [U-Boot] [PATCH v5 2/3] MX25: tx25: Avoid the usage of extern in C file X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.9 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: u-boot-bounces@lists.denx.de Errors-To: u-boot-bounces@lists.denx.de Avoid the usage of extern in C file as pointed out by checkpatch. Signed-off-by: Fabio Estevam --- Chanegs since v4: - No changes Changes since v3: - Place mx25_uart1_init_pins inside sys_proto.h Changes since v2: - Place the extern in the MX25 imx-regs.h instead of inside the MX27 imx-regs.h Changes since v1: - No changes arch/arm/include/asm/arch-mx25/sys_proto.h | 1 + board/karo/tx25/tx25.c | 2 -- 2 files changed, 1 insertions(+), 2 deletions(-) diff --git a/arch/arm/include/asm/arch-mx25/sys_proto.h b/arch/arm/include/asm/arch-mx25/sys_proto.h index 1c59c7b..f9c1420 100644 --- a/arch/arm/include/asm/arch-mx25/sys_proto.h +++ b/arch/arm/include/asm/arch-mx25/sys_proto.h @@ -23,5 +23,6 @@ void mx25_fec_init_pins(void); void imx_get_mac_from_fuse(unsigned char *mac); #endif /* CONFIG_FEC_MXC */ +void mx25_uart1_init_pins(void); #endif /* _SYS_PROTO_H_ */ diff --git a/board/karo/tx25/tx25.c b/board/karo/tx25/tx25.c index 25b99e8..c34672a 100644 --- a/board/karo/tx25/tx25.c +++ b/board/karo/tx25/tx25.c @@ -141,8 +141,6 @@ void tx25_fec_init(void) int board_init() { #ifdef CONFIG_MXC_UART - extern void mx25_uart1_init_pins(void); - mx25_uart1_init_pins(); #endif /* board id for linux */