Patchwork [U-Boot,v5,2/3] MX25: tx25: Avoid the usage of extern in C file

login
register
mail settings
Submitter Fabio Estevam
Date Sept. 5, 2011, 6:02 p.m.
Message ID <1315245763-13217-2-git-send-email-fabio.estevam@freescale.com>
Download mbox | patch
Permalink /patch/113420/
State Superseded
Delegated to: Stefano Babic
Headers show

Comments

Fabio Estevam - Sept. 5, 2011, 6:02 p.m.
Avoid the usage of extern in C file as pointed out by checkpatch.

Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
---
Chanegs since v4:
- No changes
Changes since v3:
- Place mx25_uart1_init_pins inside sys_proto.h
Changes since v2:
- Place the extern in the MX25 imx-regs.h instead of inside the MX27 imx-regs.h
Changes since v1:
- No changes
 arch/arm/include/asm/arch-mx25/sys_proto.h |    1 +
 board/karo/tx25/tx25.c                     |    2 --
 2 files changed, 1 insertions(+), 2 deletions(-)

Patch

diff --git a/arch/arm/include/asm/arch-mx25/sys_proto.h b/arch/arm/include/asm/arch-mx25/sys_proto.h
index 1c59c7b..f9c1420 100644
--- a/arch/arm/include/asm/arch-mx25/sys_proto.h
+++ b/arch/arm/include/asm/arch-mx25/sys_proto.h
@@ -23,5 +23,6 @@ 
 void mx25_fec_init_pins(void);
 void imx_get_mac_from_fuse(unsigned char *mac);
 #endif		/* CONFIG_FEC_MXC */
+void mx25_uart1_init_pins(void);
 
 #endif		/* _SYS_PROTO_H_ */
diff --git a/board/karo/tx25/tx25.c b/board/karo/tx25/tx25.c
index 25b99e8..c34672a 100644
--- a/board/karo/tx25/tx25.c
+++ b/board/karo/tx25/tx25.c
@@ -141,8 +141,6 @@  void tx25_fec_init(void)
 int board_init()
 {
 #ifdef CONFIG_MXC_UART
-	extern void mx25_uart1_init_pins(void);
-
 	mx25_uart1_init_pins();
 #endif
 	/* board id for linux */