From patchwork Fri Jul 19 11:10:10 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jeremy Sowden X-Patchwork-Id: 1134008 X-Patchwork-Delegate: pablo@netfilter.org Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netfilter-devel-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=azazel.net Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; secure) header.d=azazel.net header.i=@azazel.net header.b="QaFPTIqy"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 45qpFS1rzKz9s3l for ; Fri, 19 Jul 2019 21:10:20 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727603AbfGSLKM (ORCPT ); Fri, 19 Jul 2019 07:10:12 -0400 Received: from kadath.azazel.net ([81.187.231.250]:52162 "EHLO kadath.azazel.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727389AbfGSLKM (ORCPT ); Fri, 19 Jul 2019 07:10:12 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=azazel.net; s=20190108; h=Content-Transfer-Encoding:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=qOPFAIuBK3b+lsEwNQ4U8sEvGEkxBPaVsnbSdc6mceQ=; b=QaFPTIqy8LA4pkwsyNl6WdKG+9 cgIoy7S7TyteJWlocMTsuVLZmzh/ETkJOHdKUzTHYVITPU/l0LazqnDnDQk88WoyIVMyXk/eBsDkE uQwVIG0TLEusT6tpfSLRA9B8lSL+RCUcyLyYBgrOM/LjQtU9rV3LZ9Xu6B2XcOWqF77TpMe6L+B3a 11UzFIjHu6/acV0HmVzFam+LypUm6Co61+OCV6aWZAxTSIJ0ZZEfQj70I3qWZXsrya2MPdVIONdx/ cOrrKxfVNWsXGYhLPl1pV4cOQR6ejfG3Im4EfxQ83uJF7tGexytIhBQdb2n7Iw1qA7+adaXqVy0vo VsnTIjQA==; Received: from [2001:8b0:fb7d:d6d7:2e4d:54ff:fe4b:a9ae] (helo=ulthar.dreamlands) by kadath.azazel.net with esmtp (Exim 4.92) (envelope-from ) id 1hoQmB-00070n-1x; Fri, 19 Jul 2019 12:10:11 +0100 From: Jeremy Sowden To: Netfilter Devel Cc: Pablo Neira Ayuso , Phil Sutter Subject: [PATCH nft v2 2/2] rule: removed duplicate member initializer. Date: Fri, 19 Jul 2019 12:10:10 +0100 Message-Id: <20190719111010.14421-3-jeremy@azazel.net> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190719111010.14421-1-jeremy@azazel.net> References: <20190719103205.GM1628@orbyte.nwl.cc> <20190719111010.14421-1-jeremy@azazel.net> MIME-Version: 1.0 X-SA-Exim-Connect-IP: 2001:8b0:fb7d:d6d7:2e4d:54ff:fe4b:a9ae X-SA-Exim-Mail-From: jeremy@azazel.net X-SA-Exim-Scanned: No (on kadath.azazel.net); SAEximRunCond expanded to false Sender: netfilter-devel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netfilter-devel@vger.kernel.org Initialization of a netlink_ctx included two initializers for .nft. Removed one of them. Fixes: 2dc07bcd7eaa ("src: pass struct nft_ctx through struct netlink_ctx") Signed-off-by: Jeremy Sowden Acked-by: Phil Sutter --- src/rule.c | 1 - 1 file changed, 1 deletion(-) diff --git a/src/rule.c b/src/rule.c index b957b4571249..0ebe91e79a03 100644 --- a/src/rule.c +++ b/src/rule.c @@ -240,7 +240,6 @@ int cache_update(struct nft_ctx *nft, unsigned int flags, struct list_head *msgs .list = LIST_HEAD_INIT(ctx.list), .nft = nft, .msgs = msgs, - .nft = nft, }; struct nft_cache *cache = &nft->cache; uint32_t genid, genid_stop;