[nft,v2,2/2] rule: removed duplicate member initializer.
diff mbox series

Message ID 20190719111010.14421-3-jeremy@azazel.net
State Accepted
Delegated to: Pablo Neira
Headers show
Series
  • netlink_ctx initialization fixes.
Related show

Commit Message

Jeremy Sowden July 19, 2019, 11:10 a.m. UTC
Initialization of a netlink_ctx included two initializers for .nft.
Removed one of them.

Fixes: 2dc07bcd7eaa ("src: pass struct nft_ctx through struct netlink_ctx")
Signed-off-by: Jeremy Sowden <jeremy@azazel.net>
---
 src/rule.c | 1 -
 1 file changed, 1 deletion(-)

Comments

Phil Sutter July 19, 2019, 11:17 a.m. UTC | #1
On Fri, Jul 19, 2019 at 12:10:10PM +0100, Jeremy Sowden wrote:
> Initialization of a netlink_ctx included two initializers for .nft.
> Removed one of them.

Oh, good catch! The fact that I stared ad this code ten minutes
ago and didn't see it speaks for itself. :)

> Fixes: 2dc07bcd7eaa ("src: pass struct nft_ctx through struct netlink_ctx")
> Signed-off-by: Jeremy Sowden <jeremy@azazel.net>

Acked-by: Phil Sutter <phil@nwl.cc>

Patch
diff mbox series

diff --git a/src/rule.c b/src/rule.c
index b957b4571249..0ebe91e79a03 100644
--- a/src/rule.c
+++ b/src/rule.c
@@ -240,7 +240,6 @@  int cache_update(struct nft_ctx *nft, unsigned int flags, struct list_head *msgs
 		.list		= LIST_HEAD_INIT(ctx.list),
 		.nft		= nft,
 		.msgs		= msgs,
-		.nft		= nft,
 	};
 	struct nft_cache *cache = &nft->cache;
 	uint32_t genid, genid_stop;