[v2,2/3] dt/bindings: display: Add optional property node defined for Mali DP500
diff mbox series

Message ID 20190719095842.11683-1-wen.he_1@nxp.com
State Changes Requested
Headers show
Series
  • Untitled series #120345
Related show

Checks

Context Check Description
robh/checkpatch success

Commit Message

Wen He July 19, 2019, 9:58 a.m. UTC
Add optional property node 'arm,malidp-arqos-value' for the Mali DP500.
This property describe the ARQoS levels of DP500's QoS signaling.

Signed-off-by: Wen He <wen.he_1@nxp.com>
---
 Documentation/devicetree/bindings/display/arm,malidp.txt | 3 +++
 1 file changed, 3 insertions(+)

Comments

Liviu Dudau July 19, 2019, 11:47 a.m. UTC | #1
On Fri, Jul 19, 2019 at 05:58:42PM +0800, Wen He wrote:
> Add optional property node 'arm,malidp-arqos-value' for the Mali DP500.
> This property describe the ARQoS levels of DP500's QoS signaling.
> 
> Signed-off-by: Wen He <wen.he_1@nxp.com>

Acked-by: Liviu Dudau <liviu.dudau@arm.com>

Thanks for the patch!

Best regards,
Liviu

> ---
>  Documentation/devicetree/bindings/display/arm,malidp.txt | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/display/arm,malidp.txt b/Documentation/devicetree/bindings/display/arm,malidp.txt
> index 2f7870983ef1..76a0e7251251 100644
> --- a/Documentation/devicetree/bindings/display/arm,malidp.txt
> +++ b/Documentation/devicetree/bindings/display/arm,malidp.txt
> @@ -37,6 +37,8 @@ Optional properties:
>      Documentation/devicetree/bindings/reserved-memory/reserved-memory.txt)
>      to be used for the framebuffer; if not present, the framebuffer may
>      be located anywhere in memory.
> +  - arm,malidp-arqos-high-level: integer of u32 value describing the ARQoS
> +    levels of DP500's QoS signaling.
>  
>  
>  Example:
> @@ -54,6 +56,7 @@ Example:
>  		clocks = <&oscclk2>, <&fpgaosc0>, <&fpgaosc1>, <&fpgaosc1>;
>  		clock-names = "pxlclk", "mclk", "aclk", "pclk";
>  		arm,malidp-output-port-lines = /bits/ 8 <8 8 8>;
> +		arm,malidp-arqos-high-level = <&rqosvalue>;
>  		port {
>  			dp0_output: endpoint {
>  				remote-endpoint = <&tda998x_2_input>;
> -- 
> 2.17.1
>
Rob Herring Aug. 12, 2019, 11:19 p.m. UTC | #2
On Fri, Jul 19, 2019 at 05:58:42PM +0800, Wen He wrote:
> Add optional property node 'arm,malidp-arqos-value' for the Mali DP500.
> This property describe the ARQoS levels of DP500's QoS signaling.
> 
> Signed-off-by: Wen He <wen.he_1@nxp.com>
> ---
>  Documentation/devicetree/bindings/display/arm,malidp.txt | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/display/arm,malidp.txt b/Documentation/devicetree/bindings/display/arm,malidp.txt
> index 2f7870983ef1..76a0e7251251 100644
> --- a/Documentation/devicetree/bindings/display/arm,malidp.txt
> +++ b/Documentation/devicetree/bindings/display/arm,malidp.txt
> @@ -37,6 +37,8 @@ Optional properties:
>      Documentation/devicetree/bindings/reserved-memory/reserved-memory.txt)
>      to be used for the framebuffer; if not present, the framebuffer may
>      be located anywhere in memory.
> +  - arm,malidp-arqos-high-level: integer of u32 value describing the ARQoS
> +    levels of DP500's QoS signaling.

u32 here, and...

>  
>  
>  Example:
> @@ -54,6 +56,7 @@ Example:
>  		clocks = <&oscclk2>, <&fpgaosc0>, <&fpgaosc1>, <&fpgaosc1>;
>  		clock-names = "pxlclk", "mclk", "aclk", "pclk";
>  		arm,malidp-output-port-lines = /bits/ 8 <8 8 8>;
> +		arm,malidp-arqos-high-level = <&rqosvalue>;

phandle here?

>  		port {
>  			dp0_output: endpoint {
>  				remote-endpoint = <&tda998x_2_input>;
> -- 
> 2.17.1
>
Wen He Aug. 14, 2019, 6:35 a.m. UTC | #3
> -----Original Message-----
> From: Rob Herring <robh@kernel.org>
> Sent: 2019年8月13日 7:20
> To: Wen He <wen.he_1@nxp.com>
> Cc: linux-kernel@vger.kernel.org; dri-devel@lists.freedesktop.org;
> devicetree@vger.kernel.org; mark.rutland@arm.com; liviu.dudau@arm.com;
> brian.starkey@arm.com; airlied@linux.ie; daniel@ffwll.ch; Leo Li
> <leoyang.li@nxp.com>
> Subject: [EXT] Re: [v2 2/3] dt/bindings: display: Add optional property node
> defined for Mali DP500
> 
> 
> On Fri, Jul 19, 2019 at 05:58:42PM +0800, Wen He wrote:
> > Add optional property node 'arm,malidp-arqos-value' for the Mali DP500.
> > This property describe the ARQoS levels of DP500's QoS signaling.
> >
> > Signed-off-by: Wen He <wen.he_1@nxp.com>
> > ---
> >  Documentation/devicetree/bindings/display/arm,malidp.txt | 3 +++
> >  1 file changed, 3 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/display/arm,malidp.txt
> b/Documentation/devicetree/bindings/display/arm,malidp.txt
> > index 2f7870983ef1..76a0e7251251 100644
> > --- a/Documentation/devicetree/bindings/display/arm,malidp.txt
> > +++ b/Documentation/devicetree/bindings/display/arm,malidp.txt
> > @@ -37,6 +37,8 @@ Optional properties:
> >
> Documentation/devicetree/bindings/reserved-memory/reserved-memory.txt)
> >      to be used for the framebuffer; if not present, the framebuffer may
> >      be located anywhere in memory.
> > +  - arm,malidp-arqos-high-level: integer of u32 value describing the ARQoS
> > +    levels of DP500's QoS signaling.
> 
> u32 here, and...

Hi Rob,

Sorry, should be written as" phandle to a node describing the AQRoS levels of DP500's QoS signaling"..
Is that ok?

Best Regards,
Wen

> 
> >
> >
> >  Example:
> > @@ -54,6 +56,7 @@ Example:
> >               clocks = <&oscclk2>, <&fpgaosc0>, <&fpgaosc1>,
> <&fpgaosc1>;
> >               clock-names = "pxlclk", "mclk", "aclk", "pclk";
> >               arm,malidp-output-port-lines = /bits/ 8 <8 8 8>;
> > +             arm,malidp-arqos-high-level = <&rqosvalue>;
> 
> phandle here?
> 
> >               port {
> >                       dp0_output: endpoint {
> >                               remote-endpoint = <&tda998x_2_input>;
> > --
> > 2.17.1
> >

Patch
diff mbox series

diff --git a/Documentation/devicetree/bindings/display/arm,malidp.txt b/Documentation/devicetree/bindings/display/arm,malidp.txt
index 2f7870983ef1..76a0e7251251 100644
--- a/Documentation/devicetree/bindings/display/arm,malidp.txt
+++ b/Documentation/devicetree/bindings/display/arm,malidp.txt
@@ -37,6 +37,8 @@  Optional properties:
     Documentation/devicetree/bindings/reserved-memory/reserved-memory.txt)
     to be used for the framebuffer; if not present, the framebuffer may
     be located anywhere in memory.
+  - arm,malidp-arqos-high-level: integer of u32 value describing the ARQoS
+    levels of DP500's QoS signaling.
 
 
 Example:
@@ -54,6 +56,7 @@  Example:
 		clocks = <&oscclk2>, <&fpgaosc0>, <&fpgaosc1>, <&fpgaosc1>;
 		clock-names = "pxlclk", "mclk", "aclk", "pclk";
 		arm,malidp-output-port-lines = /bits/ 8 <8 8 8>;
+		arm,malidp-arqos-high-level = <&rqosvalue>;
 		port {
 			dp0_output: endpoint {
 				remote-endpoint = <&tda998x_2_input>;