| Message ID | 20190718151656.19820-1-phil@nwl.cc |
|---|---|
| State | Accepted |
| Delegated to: | Pablo Neira |
| Headers | show |
| Series | [nft] json: Fix memleak in timeout_policy_json() | expand |
On Thu, Jul 18, 2019 at 05:16:56PM +0200, Phil Sutter wrote: > Use the correct function when populating policy property value, > otherwise the temporary objects' refcounts are incremented. Applied, thanks Phil.
diff --git a/src/json.c b/src/json.c index 96ba557a3478b..33e0ec15f2ee1 100644 --- a/src/json.c +++ b/src/json.c @@ -266,8 +266,8 @@ static json_t *timeout_policy_json(uint8_t l4, const uint32_t *timeout) if (!root) root = json_object(); - json_object_set(root, timeout_protocol[l4].state_to_name[i], - json_integer(timeout[i])); + json_object_set_new(root, timeout_protocol[l4].state_to_name[i], + json_integer(timeout[i])); } return root ? : json_null(); }
Use the correct function when populating policy property value, otherwise the temporary objects' refcounts are incremented. Fixes: c82a26ebf7e9f ("json: Add ct timeout support") Signed-off-by: Phil Sutter <phil@nwl.cc> --- src/json.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)