| Message ID | 20190718094114.28800-1-ffmancera@riseup.net |
|---|---|
| State | Accepted |
| Delegated to: | Pablo Neira |
| Headers | show |
| Series | [nft] include: json: add missing synproxy stmt print stub | expand |
Hi Fernando, On Thu, Jul 18, 2019 at 11:41:14AM +0200, Fernando Fernandez Mancera wrote: > Fixes: 1188a69604c3 ("src: introduce SYNPROXY matching") > Signed-off-by: Fernando Fernandez Mancera <ffmancera@riseup.net> > --- > include/json.h | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/include/json.h b/include/json.h > index ce57c9f..7f2df7c 100644 > --- a/include/json.h > +++ b/include/json.h > @@ -180,6 +180,7 @@ STMT_PRINT_STUB(queue) > STMT_PRINT_STUB(verdict) > STMT_PRINT_STUB(connlimit) > STMT_PRINT_STUB(tproxy) > +STMT_PRINT_STUB(synproxy) I'm sure you need this, but how does this missing line manifests as a problem?
Hi Pablo, On 7/18/19 12:01 PM, Pablo Neira Ayuso wrote: > Hi Fernando, > > On Thu, Jul 18, 2019 at 11:41:14AM +0200, Fernando Fernandez Mancera wrote: >> Fixes: 1188a69604c3 ("src: introduce SYNPROXY matching") >> Signed-off-by: Fernando Fernandez Mancera <ffmancera@riseup.net> >> --- >> include/json.h | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/include/json.h b/include/json.h >> index ce57c9f..7f2df7c 100644 >> --- a/include/json.h >> +++ b/include/json.h >> @@ -180,6 +180,7 @@ STMT_PRINT_STUB(queue) >> STMT_PRINT_STUB(verdict) >> STMT_PRINT_STUB(connlimit) >> STMT_PRINT_STUB(tproxy) >> +STMT_PRINT_STUB(synproxy) > > I'm sure you need this, but how does this missing line manifests as a > problem? > When compiling nftables without json support I am getting the following error. statement.c:930:11: error: ‘synproxy_stmt_json’ undeclared here (not in a function); did you mean ‘tproxy_stmt_json’? .json = synproxy_stmt_json, ^~~~~~~~~~~~~~~~~~ tproxy_stmt_json
diff --git a/include/json.h b/include/json.h index ce57c9f..7f2df7c 100644 --- a/include/json.h +++ b/include/json.h @@ -180,6 +180,7 @@ STMT_PRINT_STUB(queue) STMT_PRINT_STUB(verdict) STMT_PRINT_STUB(connlimit) STMT_PRINT_STUB(tproxy) +STMT_PRINT_STUB(synproxy) #undef STMT_PRINT_STUB #undef EXPR_PRINT_STUB
Fixes: 1188a69604c3 ("src: introduce SYNPROXY matching") Signed-off-by: Fernando Fernandez Mancera <ffmancera@riseup.net> --- include/json.h | 1 + 1 file changed, 1 insertion(+)