[U-Boot] am335x_boneblack_vboot: Disable asm memcpy/memset in SPL
diff mbox series

Message ID 1563418270-18535-1-git-send-email-trini@konsulko.com
State Accepted
Commit 7c66eb49c53ef5047a77051dd6af5b0299d3010e
Delegated to: Tom Rini
Headers show
Series
  • [U-Boot] am335x_boneblack_vboot: Disable asm memcpy/memset in SPL
Related show

Commit Message

Tom Rini July 18, 2019, 2:51 a.m. UTC
In order to save a little space in SPL, do not use the asm versions of
memcpy/memset.

Signed-off-by: Tom Rini <trini@konsulko.com>
---
 configs/am335x_boneblack_vboot_defconfig | 4 ++++
 1 file changed, 4 insertions(+)

Comments

Tom Rini July 19, 2019, 12:05 a.m. UTC | #1
On Wed, Jul 17, 2019 at 10:51:10PM -0400, Tom Rini wrote:

> In order to save a little space in SPL, do not use the asm versions of
> memcpy/memset.
> 
> Signed-off-by: Tom Rini <trini@konsulko.com>

Applied to u-boot/master, thanks!
Kever Yang July 19, 2019, 9:22 a.m. UTC | #2
Hi Tom,

     The evb-rk3399 U-Boot is broken with below Merge:

         9a06eb800c  Merge branch '2019-07-17-ti-imports'

     and the previous merge work fine on evb-rk3399:
         07a5f76602 Merge branch '2019-07-17-ci-imports'

     The U-Boot get abort in initr_mmc(), any one have any ideas?
     "Synchronous Abort" handler, esr 0x96000010

Thanks,
- Kever
On 2019/7/19 上午8:05, Tom Rini wrote:
> On Wed, Jul 17, 2019 at 10:51:10PM -0400, Tom Rini wrote:
>
>> In order to save a little space in SPL, do not use the asm versions of
>> memcpy/memset.
>>
>> Signed-off-by: Tom Rini <trini@konsulko.com>
> Applied to u-boot/master, thanks!
>
>
> _______________________________________________
> U-Boot mailing list
> U-Boot@lists.denx.de
> https://lists.denx.de/listinfo/u-boot
Tom Rini July 19, 2019, 1:05 p.m. UTC | #3
On Fri, Jul 19, 2019 at 05:22:47PM +0800, Kever Yang wrote:
> Hi Tom,
> 
>     The evb-rk3399 U-Boot is broken with below Merge:
> 
>         9a06eb800c  Merge branch '2019-07-17-ti-imports'
> 
>     and the previous merge work fine on evb-rk3399:
>         07a5f76602 Merge branch '2019-07-17-ci-imports'
> 
>     The U-Boot get abort in initr_mmc(), any one have any ideas?
>     "Synchronous Abort" handler, esr 0x96000010

You should be able to bisect within those commits, and I expect it's
something from the MMC series in there.

> 
> Thanks,
> - Kever
> On 2019/7/19 上午8:05, Tom Rini wrote:
> >On Wed, Jul 17, 2019 at 10:51:10PM -0400, Tom Rini wrote:
> >
> >>In order to save a little space in SPL, do not use the asm versions of
> >>memcpy/memset.
> >>
> >>Signed-off-by: Tom Rini <trini@konsulko.com>
> >Applied to u-boot/master, thanks!
> >
> >
> >_______________________________________________
> >U-Boot mailing list
> >U-Boot@lists.denx.de
> >https://lists.denx.de/listinfo/u-boot

Patch
diff mbox series

diff --git a/configs/am335x_boneblack_vboot_defconfig b/configs/am335x_boneblack_vboot_defconfig
index ffe013fa2df7..9ccbd682412b 100644
--- a/configs/am335x_boneblack_vboot_defconfig
+++ b/configs/am335x_boneblack_vboot_defconfig
@@ -1,4 +1,8 @@ 
 CONFIG_ARM=y
+# CONFIG_SPL_USE_ARCH_MEMCPY is not set
+# CONFIG_TPL_USE_ARCH_MEMCPY is not set
+# CONFIG_SPL_USE_ARCH_MEMSET is not set
+# CONFIG_TPL_USE_ARCH_MEMSET is not set
 CONFIG_ARCH_OMAP2PLUS=y
 CONFIG_TI_COMMON_CMD_OPTIONS=y
 CONFIG_AM33XX=y