[OpenWrt-Devel] ppp: Add missing headers
diff mbox series

Message ID 20190718013552.19112-1-rosenp@gmail.com
State Awaiting Upstream
Headers show
Series
  • [OpenWrt-Devel] ppp: Add missing headers
Related show

Commit Message

Rosen Penev July 18, 2019, 1:35 a.m. UTC
Fixes compilation with -Werror=implicit-function-declaration.

Patch submitted upstream: https://github.com/paulusmack/ppp/pull/124

Signed-off-by: Rosen Penev <rosenp@gmail.com>
---
 package/network/services/ppp/Makefile         |  2 +-
 .../services/ppp/patches/700-musl.patch       | 22 +++++++++++++++++++
 2 files changed, 23 insertions(+), 1 deletion(-)
 create mode 100644 package/network/services/ppp/patches/700-musl.patch

Comments

Hans Dedecker July 18, 2019, 6:51 a.m. UTC | #1
Hi,

On Thu, Jul 18, 2019 at 3:36 AM Rosen Penev <rosenp@gmail.com> wrote:
>
> Fixes compilation with -Werror=implicit-function-declaration.
>
> Patch submitted upstream: https://github.com/paulusmack/ppp/pull/124
The upstream patch is not in line with the expected standards as
described in https://github.com/paulusmack/ppp/commit/347904e33a8a1993316e57445a1ba8243cd947ce

Hans
>
> Signed-off-by: Rosen Penev <rosenp@gmail.com>
> ---
>  package/network/services/ppp/Makefile         |  2 +-
>  .../services/ppp/patches/700-musl.patch       | 22 +++++++++++++++++++
>  2 files changed, 23 insertions(+), 1 deletion(-)
>  create mode 100644 package/network/services/ppp/patches/700-musl.patch
>
> diff --git a/package/network/services/ppp/Makefile b/package/network/services/ppp/Makefile
> index c8016dc619..7f266e126b 100644
> --- a/package/network/services/ppp/Makefile
> +++ b/package/network/services/ppp/Makefile
> @@ -9,7 +9,7 @@ include $(TOPDIR)/rules.mk
>  include $(INCLUDE_DIR)/kernel.mk
>
>  PKG_NAME:=ppp
> -PKG_RELEASE:=2
> +PKG_RELEASE:=3
>
>  PKG_SOURCE_PROTO:=git
>  PKG_SOURCE_URL:=https://github.com/paulusmack/ppp
> diff --git a/package/network/services/ppp/patches/700-musl.patch b/package/network/services/ppp/patches/700-musl.patch
> new file mode 100644
> index 0000000000..70fad9ef99
> --- /dev/null
> +++ b/package/network/services/ppp/patches/700-musl.patch
> @@ -0,0 +1,22 @@
> +From bbe58b9f83ba197d1cca1ca4338214e35f6131c8 Mon Sep 17 00:00:00 2001
> +From: Rosen Penev <rosenp@gmail.com>
> +Date: Tue, 2 Jul 2019 12:53:12 -0700
> +Subject: [PATCH] pppd.h: Add missing headers
> +
> +---
> + pppd/pppd.h | 2 ++
> + 1 file changed, 2 insertions(+)
> +
> +diff --git a/pppd/pppd.h b/pppd/pppd.h
> +index 6e3743fd..b3470571 100644
> +--- a/pppd/pppd.h
> ++++ b/pppd/pppd.h
> +@@ -50,6 +50,8 @@
> + #define __PPPD_H__
> +
> + #include <stdio.h>            /* for FILE */
> ++#include <stdlib.h>           /* for encrypt */
> ++#include <unistd.h>           /* for setkey */
> + #include <limits.h>           /* for NGROUPS_MAX */
> + #include <sys/param.h>                /* for MAXPATHLEN and BSD4_4, if defined */
> + #include <sys/types.h>                /* for u_int32_t, if defined */
> --
> 2.17.1
>
>
> _______________________________________________
> openwrt-devel mailing list
> openwrt-devel@lists.openwrt.org
> https://lists.openwrt.org/mailman/listinfo/openwrt-devel

Patch
diff mbox series

diff --git a/package/network/services/ppp/Makefile b/package/network/services/ppp/Makefile
index c8016dc619..7f266e126b 100644
--- a/package/network/services/ppp/Makefile
+++ b/package/network/services/ppp/Makefile
@@ -9,7 +9,7 @@  include $(TOPDIR)/rules.mk
 include $(INCLUDE_DIR)/kernel.mk
 
 PKG_NAME:=ppp
-PKG_RELEASE:=2
+PKG_RELEASE:=3
 
 PKG_SOURCE_PROTO:=git
 PKG_SOURCE_URL:=https://github.com/paulusmack/ppp
diff --git a/package/network/services/ppp/patches/700-musl.patch b/package/network/services/ppp/patches/700-musl.patch
new file mode 100644
index 0000000000..70fad9ef99
--- /dev/null
+++ b/package/network/services/ppp/patches/700-musl.patch
@@ -0,0 +1,22 @@ 
+From bbe58b9f83ba197d1cca1ca4338214e35f6131c8 Mon Sep 17 00:00:00 2001
+From: Rosen Penev <rosenp@gmail.com>
+Date: Tue, 2 Jul 2019 12:53:12 -0700
+Subject: [PATCH] pppd.h: Add missing headers
+
+---
+ pppd/pppd.h | 2 ++
+ 1 file changed, 2 insertions(+)
+
+diff --git a/pppd/pppd.h b/pppd/pppd.h
+index 6e3743fd..b3470571 100644
+--- a/pppd/pppd.h
++++ b/pppd/pppd.h
+@@ -50,6 +50,8 @@
+ #define __PPPD_H__
+ 
+ #include <stdio.h>		/* for FILE */
++#include <stdlib.h>		/* for encrypt */
++#include <unistd.h>		/* for setkey */
+ #include <limits.h>		/* for NGROUPS_MAX */
+ #include <sys/param.h>		/* for MAXPATHLEN and BSD4_4, if defined */
+ #include <sys/types.h>		/* for u_int32_t, if defined */